Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nexus] Reconfigurator Rendezvous background task should report useful status #7392

Closed
jgallagher opened this issue Jan 23, 2025 · 0 comments · Fixed by #7401
Closed

[nexus] Reconfigurator Rendezvous background task should report useful status #7392

jgallagher opened this issue Jan 23, 2025 · 0 comments · Fixed by #7401

Comments

@jgallagher
Copy link
Contributor

It would be nice to be able to inspect the most recent execution of the blueprint_rendezvous task and see, for each rendezvous table:

  • How many new records were inserted
  • How many records did the task want to insert (based on the blueprint) but did not because the relevant resources weren't present in the latest inventory collection
  • How many existing records were tombstoned
This was referenced Jan 23, 2025
Open
Merged
jgallagher added a commit that referenced this issue Jan 24, 2025
@jgallagher
Flesh out status report from reconfigurator rendezvous RPW
c1d771f 
Closes #7392.
@jgallagher jgallagher mentioned this issue Jan 24, 2025
Merged
jgallagher added a commit that referenced this issue Jan 28, 2025
@jgallagher
[reconfigurator] Move insertions into crucible_dataset from executo…
8f7a673 
…r RPW to rendezvous RPW (#7397)

This PR builds on #7386. I'll test both of them together on a racklette
(will put results in a comment on this PR).

This PR contributes to addressing (but doesn't fully address) a couple
issues:

* #7392: This PR adds useful output for the `crucible_dataset`
rendezvous table, but we still need useful output for `debug_dataset`
* #6999: This PR removes a step from execution that currently depends on
successful completion of earlier step to post datasets to sled-agents,
since we now confirm insertions are okay via inventory collection

I'm inclined to say this PR fully addresses a couple other issues, but
it's debatable:

* #7210: Are we okay with IP and port still being here now that this
table is just crucible datasets? (IMO it's still conceptually weird to
say a dataset has an IP/port, but maybe it's not as bad now?)
* #6998 `dataset` as a general table is now gone and replaced with more
specific rendezvous tables, so I think this one can be closed?
jgallagher added a commit that referenced this issue Jan 28, 2025
@jgallagher
Flesh out status report from reconfigurator rendezvous RPW
cdfa130 
Closes #7392.
jgallagher added a commit that referenced this issue Jan 28, 2025
@jgallagher
Flesh out status report from reconfigurator rendezvous RPW (#7401)
2f1373e 
Example output from `omicron-dev run-all` (so no meaningful rows, but
just checking the field formatting and omdb deserialization):

```
task: "blueprint_rendezvous"
  configured period: every 5m
  currently executing: no
  last completed activation: iter 5, triggered by a dependent task completing
    started at 2025-01-24T21:07:40.740Z (222s ago) and ran for 68ms
    target blueprint:     72d199ef-d6bd-4895-8858-006f3ed212ad
    inventory collection: 7dfbf99c-3613-498c-a871-cfb9b2945abe
    debug_dataset rendezvous counts:
        num_inserted:           0
        num_already_exist:      0
        num_not_in_inventory:   0
        num_tombstoned:         0
        num_already_tombstoned: 0
    crucible_dataset rendezvous counts:
        num_inserted:         0
        num_already_exist:    0
        num_not_in_inventory: 0
```

Closes #7392.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flesh out status report from reconfigurator rendezvous RPW oxidecomputer/omicron
1 participant
@jgallagher