Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nexus] Support Bundle API Skeleton #7008

Merged
merged 27 commits into from
Jan 6, 2025
Merged

[nexus] Support Bundle API Skeleton #7008

merged 27 commits into from
Jan 6, 2025

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Nov 7, 2024

PR 1 / ???

Adds support bundles to the experimental Nexus API.
All methods exist, but return "not implemented" errors.

These methods will be implemented in a later PR: #7187

@smklein smklein changed the title [nexus] Add support bundle API skeleton to Nexus [nexus] Add Support Bundle API skeleton to Nexus Nov 14, 2024
@smklein smklein changed the title [nexus] Add Support Bundle API skeleton to Nexus [nexus] Add Support Bundle API skeleton Nov 14, 2024
@smklein smklein changed the title [nexus] Add Support Bundle API skeleton [nexus] Support Bundle API Skeleton Nov 14, 2024
@smklein smklein marked this pull request as ready for review December 10, 2024 02:03
Copy link
Contributor

@wfchandler wfchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

common/src/api/external/mod.rs Outdated Show resolved Hide resolved
common/src/api/external/mod.rs Outdated Show resolved Hide resolved
smklein added a commit that referenced this pull request Dec 17, 2024
Responding to feedback in
#7008 (comment)
, this PR aligns the Sled Agent Support Bundle API with the incoming
Nexus Support Bundle API (in
#7008)
@smklein smklein merged commit 1200dcb into main Jan 6, 2025
17 checks passed
@smklein smklein deleted the nexus-support-bundles-api branch January 6, 2025 23:16
smklein added a commit that referenced this pull request Jan 15, 2025
PR 5 / ???

Implements support bundle APIs for accessing storage bundles.
Range request support is only partially implemented as-is -- follow-up support is described in #7356

Builds atop the API skeleton in:
- #7008

Uses the support bundle datastore interfaces in:
- #7021

Relies on the background task in:
- #7063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants