[reconfigurator][support-bundles] Choose datasets for support bundles from current blueprint #7330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After much discussion, I'm closing this because it introduces an unfortunate flake opportunity: we could pick a dataset from the blueprint that hasn't yet been created, since blueprints represent intended state. RFD 541 will expand on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incremental step towards #6998: we want to transition the
datasettable to exclusively-for-crucible, so this removes one consumer of it.The bulk of the diff is adding a couple of diesel extensions, heavily derived from
ApplyBlueprintZoneFilterExt. (One is a literal copy/paste thens/zone/dataset/g.) The other is a helper to filter a few of the blueprint tables down to just the current target blueprint, which both this query and the other query-the-blueprint consumer we have today wants (the VPC code, which changes here to use the new helper).