[oxlog] skip unnecessary lstat #7372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
andrewjstone
approved these changes
Jan 17, 2025
Created using spr 1.3.6-beta.1
|
The test failure here looks a lot like #7255 but there was a fix for that. Poking some before I rerun the failed test... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not incur the cost of calling
lstaton every log file oxlog walks over when we are returning all log files regardless of size. If someone requests that we don't show 0 length files through oxlog the binary or the library then we will do thelstatin order to check the file length.I originally found this edge case when operating on a sled with 600k plus log files that were being walked. Figuring out what we want to do about aging out old debug logs is out of the scope of this PR.