Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode devcontainer not building #3114

Closed
daltonv opened this issue Nov 14, 2023 · 0 comments · Fixed by #3115
Closed

VSCode devcontainer not building #3114

daltonv opened this issue Nov 14, 2023 · 0 comments · Fixed by #3115
Labels
bug Something isn't working

Comments

@daltonv
Copy link
Contributor

daltonv commented Nov 14, 2023

Describe the bug
The VSCode devcontainer fails to build on main

To Reproduce
Steps to reproduce the behavior:

  1. Clone the current main branch and open in VSCode.
  2. Attempt to start the devcontainer

Expected behavior
Devcontainer should build

Additional context
This looks to be simple typo with the name of the requirements.txt in the Dockerfile

COPY .config/python/dev/requirements.txt /tmp/pip-tmp/
RUN pip3 --disable-pip-version-check --no-cache-dir install -r /tmp/pip-tmp/requirements.dev.txt \
   && rm -rf /tmp/pip-tmp

We try to install requirements.dev.txt but that doesn't exist.
@daltonv daltonv added the bug Something isn't working label Nov 14, 2023
daltonv added a commit to daltonv/megalinter that referenced this issue Nov 14, 2023
@daltonv
Fix devcontainer Dockerfile typo (fixes oxsecurity#3114)
4cd7129 
There was a small typo with the name of the requirements.txt file that
prevented the whole image from being built.
daltonv added a commit to daltonv/megalinter that referenced this issue Nov 14, 2023
@daltonv
Fix devcontainer Dockerfile typo (fixes oxsecurity#3114)
b9773b0 
There was a small typo with the name of the requirements.txt file that
prevented the whole image from being built.
@daltonv daltonv mentioned this issue Nov 14, 2023
Merged
4 tasks
echoix added a commit that referenced this issue Nov 18, 2023
@daltonv @echoix @nvuillam
Fix devcontainer Dockerfile typo (fixes #3114) (#3115)
7420370 
* Fix devcontainer Dockerfile typo (fixes #3114)

There was a small typo with the name of the requirements.txt file that
prevented the whole image from being built.

* Remove outdated comment from devcontainer Dockerfile

This comment is no longer relvant and will just confure users.

---------

Co-authored-by: Edouard Choinière <[email protected]>
Co-authored-by: Nicolas Vuillamy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix devcontainer Dockerfile typo (fixes #3114) daltonv/megalinter
1 participant
@daltonv