Dotnet Upgrade project files #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lextatic
changed the title
|
@lextatic thanks a lot :) |
nvuillam
added a commit
that referenced
this pull request
Jan 6, 2023
* Upgrade dotnet to v6 + list_of_files for dotnet-format * Fixes * Fixes * Adding dotnet project files * Better .cs examples of bad code * Dotnet Upgrade project files (#1679) * Adding dotnet project files * Better .cs examples of bad code Co-authored-by: Alexandre Melotti <[email protected]> * Update doc * Adding .csproj files to sample_project_fixes * Added .sln info on linter_text property * Updated linter URL and added {{WORKSPACE}} CLI arg * Unifying vb and csharp projects into one single solution * Upgrade dotnet version on linter dockers * Really upgrade dotnet everywhere * Revert "Upgrade dotnet version on linter dockers" This reverts commit 995e9df. * Testing some Dockerfile configs * dotnet info * Trying to figure out dotnet version running on each test case * Checking root's workspace * Checking for tool versions * Removing dotnet-format install from Docker images * Updating linter versions and helps for dotnet-format * Reverting pre_coomands and configuring new dotnet format params * Forgot the "format" argument * Updating test reports * Fixed ERROR paths * Undowngrade DevSkim version * changelog * Remove version from DevSkim install line * Update TSQLLint version * fix dotnet format call * Using relative paths for worksapces * Detailed logging for debug * Revert "Using relative paths for worksapces" This reverts commit 92f57bc. * Disabling list_of_files mode. * Reverting back to list_of_files * Echoing linting command * Checking workspace path * Fixing descriptor parsing * Fix parse * Trying to figure out why --include is failing * Testing the exact computed command manually * Testing relative paths * Checking file contnt before testing linter * Checking editorconfig contents * Adding editorconfigs to validate whitespaces. Also reverting all changes to descriptors. * Re-enabling detailed logging * Adding style error to csharp_bad_02.cs. * Testing whitespace formatting for vb only * I don't know anymore * Fixed VB descriptor * A few mroe tests with editorconfigs * Fixed pre-command syntax * Testing lint without --include parameter * Trying several path styles * Testing some different paths * Testing echo * More tests * Checking versions * Adding dotnet --info * Upgrade to dotnet 7 and removed list_of_files * Revert some changes for --list-of-files * More experiments * Ops * Fixing malformed file * Whoa, python sux * Change dotnet command * Updating reports for tests * Success linters also format bad files * Separating good and bad test projects * Revert back to dotnet6 * Updated success report files * Removing unused import from DotnetFormatLinter.py * Upgrade to dotnet 7 * Removing csharpier version specification from install cli * Revert "Upgrade to dotnet 7" This reverts commit 7630633. * Updating changelog, removed 'list_of_files' for now Co-authored-by: nvuillam <[email protected]> Co-authored-by: Alexandre Melotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project files for the updated dotnet-format.
Also changed the bad.cs files that were binary for some reason. If this was really intended I could revert those changes.
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance