-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix internal git diff --check #2190
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ BASH | bash-exec | 7 | 0 | 0.01s | |
✅ BASH | shellcheck | 7 | 0 | 0.38s | |
✅ BASH | shfmt | 7 | 0 | 0 | 0.26s |
✅ COPYPASTE | jscpd | yes | no | 1.93s | |
✅ DOCKERFILE | hadolint | 105 | 0 | 7.82s | |
✅ JSON | eslint-plugin-jsonc | 21 | 0 | 0 | 1.98s |
✅ JSON | jsonlint | 19 | 0 | 0.22s | |
✅ JSON | v8r | 21 | 0 | 14.69s | |
markdownlint | 299 | 0 | 133 | 5.16s | |
✅ MARKDOWN | markdown-link-check | 299 | 0 | 4.93s | |
✅ MARKDOWN | markdown-table-formatter | 299 | 0 | 0 | 13.28s |
✅ OPENAPI | spectral | 1 | 0 | 0.72s | |
bandit | 173 | 43 | 2.32s | ||
✅ PYTHON | black | 173 | 0 | 0 | 3.96s |
✅ PYTHON | flake8 | 173 | 0 | 3.94s | |
✅ PYTHON | isort | 173 | 0 | 0 | 0.63s |
✅ PYTHON | mypy | 173 | 0 | 6.62s | |
✅ PYTHON | pylint | 173 | 0 | 10.61s | |
pyright | 173 | 279 | 17.84s | ||
✅ REPOSITORY | checkov | yes | no | 25.82s | |
✅ REPOSITORY | git_diff | yes | no | 0.26s | |
✅ REPOSITORY | secretlint | yes | no | 6.25s | |
✅ REPOSITORY | trivy | yes | no | 24.74s | |
✅ SPELL | cspell | 716 | 0 | 18.05s | |
✅ SPELL | misspell | 538 | 0 | 0 | 0.68s |
✅ XML | xmllint | 3 | 0 | 0.0s | |
✅ YAML | prettier | 80 | 0 | 0 | 3.2s |
✅ YAML | v8r | 22 | 0 | 43.26s | |
✅ YAML | yamllint | 81 | 0 | 1.33s |
See detailed report in MegaLinter reports
Does this PR modify all line endings in some way or something like that? I ask since I know there is a lot of vibrant activity on this repository over the holidays, and I anticipate some confusion from contributors rebasing across this sweeping change. |
@Kurt-von-Laven i thought I fixed the git-diff bug but... it does not work :/ |
Oh, gotcha. Is this the symptom this PR seeks to address? |
Yes :/ |
Codecov Report
@@ Coverage Diff @@
## main #2190 +/- ##
==========================================
+ Coverage 82.36% 82.43% +0.07%
==========================================
Files 167 168 +1
Lines 4439 4451 +12
==========================================
+ Hits 3656 3669 +13
+ Misses 783 782 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ BASH | bash-exec | 7 | 0 | 0.02s | |
✅ BASH | shellcheck | 7 | 0 | 0.4s | |
✅ BASH | shfmt | 7 | 0 | 0 | 0.04s |
✅ COPYPASTE | jscpd | yes | no | 2.08s | |
✅ DOCKERFILE | hadolint | 105 | 0 | 10.3s | |
✅ JSON | eslint-plugin-jsonc | 21 | 0 | 0 | 1.84s |
✅ JSON | jsonlint | 19 | 0 | 0.2s | |
✅ JSON | npm-package-json-lint | yes | no | 0.56s | |
✅ JSON | v8r | 21 | 0 | 14.08s | |
markdownlint | 299 | 0 | 133 | 4.96s | |
✅ MARKDOWN | markdown-link-check | 299 | 0 | 5.57s | |
✅ MARKDOWN | markdown-table-formatter | 299 | 0 | 0 | 13.48s |
✅ OPENAPI | spectral | 1 | 0 | 0.77s | |
bandit | 173 | 43 | 2.37s | ||
✅ PYTHON | black | 173 | 0 | 0 | 3.73s |
✅ PYTHON | flake8 | 173 | 0 | 1.92s | |
✅ PYTHON | isort | 173 | 0 | 0 | 0.41s |
✅ PYTHON | mypy | 173 | 0 | 7.39s | |
✅ PYTHON | pylint | 173 | 0 | 11.15s | |
pyright | 173 | 277 | 16.93s | ||
✅ REPOSITORY | checkov | yes | no | 26.99s | |
devskim | yes | 60 | 1.19s | ||
✅ REPOSITORY | dustilock | yes | no | 1.79s | |
✅ REPOSITORY | git_diff | yes | no | 0.04s | |
✅ REPOSITORY | secretlint | yes | no | 3.49s | |
✅ REPOSITORY | syft | yes | no | 2.73s | |
✅ REPOSITORY | trivy | yes | no | 20.84s | |
✅ SPELL | cspell | 716 | 0 | 17.64s | |
✅ SPELL | misspell | 538 | 0 | 0 | 0.43s |
✅ XML | xmllint | 3 | 0 | 0.0s | |
✅ YAML | prettier | 80 | 0 | 0 | 2.4s |
✅ YAML | v8r | 22 | 0 | 42.58s | |
✅ YAML | yamllint | 81 | 0 | 1.35s |
See detailed report in MegaLinter reports
You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.
No description provided.