Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to docker buildx #2199

Merged
merged 9 commits into from
Jan 1, 2023

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Dec 29, 2022

In order to unlock #1553 we start with what @echoix comments: #1553 (comment)

@bdovaz bdovaz requested a review from nvuillam as a code owner December 29, 2022 23:11
.github/workflows/auto-update-linters.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-DEV.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-DEV.yml Outdated Show resolved Hide resolved
@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 30, 2022

Thanks @echoix for the suggestions.

@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 30, 2022

@echoix do you know what happened in the build? It seems that the build has been done well but in the next step that makes docker run of the previously generated image, it seems that it does not find it.

Edit: It seems to have something to do with not passing the --load parameter to it.

https://docs.docker.com/engine/reference/commandline/buildx_build/#load

@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 31, 2022

@nvuillam I got this error:

image

image

@nvuillam
Copy link
Member

Sometimes it happens, you just have to run the job again:)

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2022

Codecov Report

Merging #2199 (96962b7) into main (9019e8a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2199      +/-   ##
==========================================
+ Coverage   82.97%   82.99%   +0.02%     
==========================================
  Files         170      170              
  Lines        4469     4469              
==========================================
+ Hits         3708     3709       +1     
+ Misses        761      760       -1     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nvuillam
Copy link
Member

@bdovaz you forgot a sh file to update ^^

image

bdovaz added 2 commits January 1, 2023 20:22
Add a new DOCKER_BUILD_PLATFORMS variable in upload-docker.sh
@bdovaz
Copy link
Collaborator Author

bdovaz commented Jan 1, 2023

@nvuillam I think it is ready

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)
Let's see if it goes well with the deploy BETA jobs :)

@nvuillam nvuillam merged commit b359f69 into oxsecurity:main Jan 1, 2023
@bdovaz bdovaz deleted the feature/switch-to-docker-buildx branch January 1, 2023 21:09
@nvuillam
Copy link
Member

nvuillam commented Jan 1, 2023

thanks a lot @echoix for the help :)

@bdovaz bdovaz mentioned this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants