-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to docker buildx #2199
Switch to docker buildx #2199
Conversation
Co-authored-by: Edouard Choinière <[email protected]>
Co-authored-by: Edouard Choinière <[email protected]>
Co-authored-by: Edouard Choinière <[email protected]>
Thanks @echoix for the suggestions. |
@echoix do you know what happened in the build? It seems that the build has been done well but in the next step that makes docker run of the previously generated image, it seems that it does not find it. Edit: It seems to have something to do with not passing the --load parameter to it. https://docs.docker.com/engine/reference/commandline/buildx_build/#load |
@nvuillam I got this error: |
Sometimes it happens, you just have to run the job again:) |
Codecov Report
@@ Coverage Diff @@
## main #2199 +/- ##
==========================================
+ Coverage 82.97% 82.99% +0.02%
==========================================
Files 170 170
Lines 4469 4469
==========================================
+ Hits 3708 3709 +1
+ Misses 761 760 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@bdovaz you forgot a sh file to update ^^ |
Add a new DOCKER_BUILD_PLATFORMS variable in upload-docker.sh
@nvuillam I think it is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :)
Let's see if it goes well with the deploy BETA jobs :)
thanks a lot @echoix for the help :) |
In order to unlock #1553 we start with what @echoix comments: #1553 (comment)