-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dotnet format install command #2311
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ BASH | bash-exec | 7 | 0 | 0.01s | |
✅ BASH | shellcheck | 7 | 0 | 0.39s | |
✅ BASH | shfmt | 7 | 0 | 0 | 0.34s |
✅ COPYPASTE | jscpd | yes | no | 2.66s | |
✅ DOCKERFILE | hadolint | 105 | 0 | 10.11s | |
✅ JSON | eslint-plugin-jsonc | 21 | 0 | 0 | 2.06s |
✅ JSON | jsonlint | 19 | 0 | 0.25s | |
✅ JSON | v8r | 21 | 0 | 14.22s | |
markdownlint | 309 | 0 | 229 | 6.64s | |
✅ MARKDOWN | markdown-link-check | 309 | 0 | 5.41s | |
✅ MARKDOWN | markdown-table-formatter | 309 | 0 | 0 | 18.69s |
✅ OPENAPI | spectral | 1 | 0 | 0.85s | |
bandit | 176 | 45 | 2.35s | ||
✅ PYTHON | black | 176 | 0 | 0 | 5.12s |
✅ PYTHON | flake8 | 176 | 0 | 2.07s | |
✅ PYTHON | isort | 176 | 0 | 0 | 0.74s |
✅ PYTHON | mypy | 176 | 0 | 7.37s | |
✅ PYTHON | pylint | 176 | 0 | 13.41s | |
pyright | 176 | 276 | 18.91s | ||
✅ REPOSITORY | checkov | yes | no | 28.52s | |
✅ REPOSITORY | git_diff | yes | no | 0.37s | |
✅ REPOSITORY | secretlint | yes | no | 8.45s | |
✅ REPOSITORY | trivy | yes | no | 23.4s | |
✅ SPELL | cspell | 730 | 0 | 19.59s | |
✅ SPELL | misspell | 551 | 0 | 0 | 0.85s |
✅ XML | xmllint | 3 | 0 | 0 | 0.33s |
✅ YAML | prettier | 81 | 0 | 0 | 2.83s |
✅ YAML | v8r | 23 | 0 | 62.78s | |
✅ YAML | yamllint | 82 | 0 | 1.63s |
See detailed report in MegaLinter reports
The title may be misleading, we are removing dotnet-format (the tool), not the dotnet format. We might as well change the "linter name", to have the documentation page not having contradictions. => would there be any obvious side effects? (Like does it break too much links, does something else depend on the exact name?) |
linter_name can probably be updated without major break, but I can't promise about documentation... so better not change it ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, it will decrease the size of some docker images ^^
tflint failing test case is because of github API limits , so I forced the merge ^^ |
In .NET 6 it is included in the SDK
#2310 (comment)