Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dotnet format install command #2311

Merged
merged 4 commits into from
Feb 5, 2023
Merged

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Feb 5, 2023

In .NET 6 it is included in the SDK

#2310 (comment)

@bdovaz bdovaz requested a review from nvuillam as a code owner February 5, 2023 18:20
@nvuillam
Copy link
Member

nvuillam commented Feb 5, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.01s
✅ BASH shellcheck 7 0 0.39s
✅ BASH shfmt 7 0 0 0.34s
✅ COPYPASTE jscpd yes no 2.66s
✅ DOCKERFILE hadolint 105 0 10.11s
✅ JSON eslint-plugin-jsonc 21 0 0 2.06s
✅ JSON jsonlint 19 0 0.25s
✅ JSON v8r 21 0 14.22s
⚠️ MARKDOWN markdownlint 309 0 229 6.64s
✅ MARKDOWN markdown-link-check 309 0 5.41s
✅ MARKDOWN markdown-table-formatter 309 0 0 18.69s
✅ OPENAPI spectral 1 0 0.85s
⚠️ PYTHON bandit 176 45 2.35s
✅ PYTHON black 176 0 0 5.12s
✅ PYTHON flake8 176 0 2.07s
✅ PYTHON isort 176 0 0 0.74s
✅ PYTHON mypy 176 0 7.37s
✅ PYTHON pylint 176 0 13.41s
⚠️ PYTHON pyright 176 276 18.91s
✅ REPOSITORY checkov yes no 28.52s
✅ REPOSITORY git_diff yes no 0.37s
✅ REPOSITORY secretlint yes no 8.45s
✅ REPOSITORY trivy yes no 23.4s
✅ SPELL cspell 730 0 19.59s
✅ SPELL misspell 551 0 0 0.85s
✅ XML xmllint 3 0 0 0.33s
✅ YAML prettier 81 0 0 2.83s
✅ YAML v8r 23 0 62.78s
✅ YAML yamllint 82 0 1.63s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented Feb 5, 2023

The title may be misleading, we are removing dotnet-format (the tool), not the dotnet format.

We might as well change the "linter name", to have the documentation page not having contradictions. => would there be any obvious side effects? (Like does it break too much links, does something else depend on the exact name?)
At least the env variable name would be the same and correct, not like the poor choice of the first powershell linter that was called powershell instead of PSScriptAnalyzer.

@bdovaz bdovaz changed the title Remove dotnet format install Remove dotnet format install command Feb 5, 2023
@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 5, 2023

@nvuillam about the linter_name property question do you know anything? In theory I understand that it would not generate any breaking change no? That only affects the documentation I imagine.

@echoix I guess you want to change it to linter_name: dotnet format? Or do you mean something else?

@nvuillam
Copy link
Member

nvuillam commented Feb 5, 2023

linter_name can probably be updated without major break, but I can't promise about documentation... so better not change it ^^

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, it will decrease the size of some docker images ^^

@nvuillam nvuillam merged commit b0bb50f into main Feb 5, 2023
@nvuillam nvuillam deleted the dev/remove-dotnet-format-install branch February 5, 2023 20:09
@nvuillam
Copy link
Member

nvuillam commented Feb 5, 2023

tflint failing test case is because of github API limits , so I forced the merge ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants