Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for idea plugins auto-install #2553

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Add support for idea plugins auto-install #2553

merged 6 commits into from
Apr 12, 2023

Conversation

waterfoul
Copy link
Contributor

@waterfoul waterfoul commented Apr 11, 2023 •
edited by echoix
Loading

Proposed Changes

  1. Adds additional logic to python and additional yaml to support creating a file which triggers intellij based IDEs to install the plugins

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@waterfoul waterfoul requested a review from nvuillam as a code owner April 11, 2023 19:55
@echoix echoix added the enhancement New feature or request label Apr 11, 2023
echoix
echoix requested changes Apr 11, 2023
View reviewed changes
docs/reporters/ConfigReporter.md Outdated Show resolved Hide resolved
waterfoul and others added 2 commits April 11, 2023 15:42
@waterfoul @echoix
Casing tweak
7da770a 
Co-authored-by: Edouard Choinière <[email protected]>
@waterfoul
Add cspell ignores
a2527b8
nvuillam
nvuillam requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great, thanks for the PR :)
Please can you add cspell exceptions into .cspell json instead of inline comments ?
MegaLinter provides a reasy to ise updated cspell file in artifacts
Thanks :)

@waterfoul
Copy link
Contributor Author

Seems great, thanks for the PR :) Please can you add cspell exceptions into .cspell json instead of inline comments ? MegaLinter provides a reasy to ise updated cspell file in artifacts Thanks :)

Which .cspell.json file should I update? There are a few and none of them are at the root

@Kurt-von-Laven
Copy link
Collaborator

.github/linters/.cspell.json

@waterfoul waterfoul requested review from nvuillam and echoix April 12, 2023 15:50
@echoix echoix enabled auto-merge (squash) April 12, 2023 16:56
@echoix echoix merged commit 5b8dfd4 into oxsecurity:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

@nvuillam nvuillam nvuillam approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waterfoul @Kurt-von-Laven @nvuillam @echoix