Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ops: Updated DevSkim to have a default configuration file and reduce errors (closes #3017) #3024

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Ops: Updated DevSkim to have a default configuration file and reduce errors (closes #3017) #3024

merged 3 commits into from
Oct 20, 2023

Conversation

andrewvaughan
Copy link
Contributor

Fixes #3017

Proposed Changes

  1. Add a default .devskim.json for the linter to remove errors with this missing

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@andrewvaughan andrewvaughan temporarily deployed to dev October 19, 2023 18:11 — with GitHub Actions Inactive
@andrewvaughan andrewvaughan temporarily deployed to dev October 19, 2023 18:11 — with GitHub Actions Inactive
@andrewvaughan
Copy link
Contributor Author

I believe that I followed the pattern appropriately for adding a new default configuration file - please review that I didn't miss anything anywhere.

nvuillam
nvuillam approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well played @andrewvaughan , many thanks :)

@nvuillam nvuillam merged commit ab7e69c into oxsecurity:main Oct 20, 2023
@andrewvaughan andrewvaughan deleted the feat/3017/devskim-default-config branch October 21, 2023 01:48
@nvuillam nvuillam mentioned this pull request Oct 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvuillam nvuillam nvuillam approved these changes

@echoix echoix Awaiting requested review from echoix echoix is a code owner

@bdovaz bdovaz Awaiting requested review from bdovaz bdovaz is a code owner

@Kurt-von-Laven Kurt-von-Laven Awaiting requested review from Kurt-von-Laven Kurt-von-Laven is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DevSkim failing both locally and on GH Actions
2 participants
@andrewvaughan @nvuillam