-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pymdown-extensions and markdown #3053
Conversation
I've only tested the local dev workflow, but I believe the others should work fine. |
entrypoint.sh
Outdated
@@ -35,7 +35,7 @@ if [ "${UPGRADE_LINTERS_VERSION}" == "true" ]; then | |||
# Run only get_linter_help test methods | |||
pytest -v --durations=0 -k _get_linter_help megalinter/ | |||
# Reinstall mkdocs-material because of broken dependency | |||
pip3 install --upgrade "markdown==3.3.7" mike mkdocs-material "pymdown-extensions==9.11" "mkdocs-glightbox==0.3.2" mdx_truly_sane_lists jsonschema json-schema-for-humans giturlparse webpreview "github-dependents-info==0.10.0" | |||
pip3 install --upgrade -r .config/python/dev/requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This however might not work, since I don't think that that file is copied inside the released docker images. The entrypoint.sh script is what is ran when running the docker images. Should we either include the dependencies file, or find a way to keep the deps needed (and not installed by default, like node's dev dependencies), or keep it manually in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted (with changed versions) and added note to keep in sync.
Did you have the chance to run your built image with the env var Lines 29 to 41 in e2d2f6e
It is the equivalent of megalinter/.github/workflows/auto-update-linters.yml Lines 93 to 100 in e2d2f6e
|
3e741dd
to
979bc38
Compare
Wasn't able to test that path. Should I just revert that part? |
979bc38
to
85091f0
Compare
I don't believe the GitPod issue was related to this PR. |
Also merges where python dependencies are specified to requirements.txt. Except for entrypoint.sh which needs to be kepy in sync, added note in requirement.txt for that. Fixes: oxsecurity#3041
efc8575
to
89cb242
Compare
Nope, it's fixed now. There was the download server for node that was down a bit |
Lychee failure : wbond/packagecontrol.io#164 |
Ooos, seems like Mike was removed and not added to the requirements file. I thought I doubled checked that all the equivalent dependencies were there |
Also merges where python dependencies are specified to requirements.txt.
Fixes #3041
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance