Format powershell linter output into terminal-wide table

[efrecon]

Fixes #3313 and #3320

Proposed Changes

Improve the output format of the powershell linter by ensuring that the columns utilise the entire terminal width. This improves readability of both the description message and the location of the offending problem. Extra care is necessary to bypass a known powershell bug on UNIX-like systems.

Readiness Checklist

Author/Contributor

• Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
• If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

• Label as breaking if this is a large fundamental change
• Label as either automation, bug, documentation, enhancement, infrastructure, or performance

[efrecon]

I see that the tests fail. This is because the output has changed and is not clamped to 80 characters anymore.

An "easy" solution would be to arrange for the content of the ERROR-POWERSHELL_POWERSHELL.txt file to be the same as the one when running the tests at GitHub. Where can I find the output in the GitHub workflow logs/files?

A better solution, i.e. working in all cases, would require to add a new environment variable called POWERSHELL_POWERSHELL_OUTPUT_WIDTH (or similar) and to:

1. Control and enforce the content of that variable during the tests.
2. Arrange for the output file to match (or don't change and enforce at 80)

Which solution is best and how can we enforce the content of an environment variable during a test?

[nvuillam]

@efrecon The error seems related to the fact that the terminal is not tty (basically means that it is not interactive)

        if self.linter_name == "powershell":
            # Format output to fit in terminal, respecting the terminal width.
            # For more info: https://stackoverflow.com/a/76889369
>           size = os.get_terminal_size()
E           OSError: [Errno 25] Not a tty

You should implement a fallback with a default size, or even just define a default size, as terminal will never be interactive, and it should work :)

[efrecon]

Now integrates fixes for #3320 as well

[nvuillam]

sorry for the delay, i'm very busy these day ^^
Thanks for the new commits, let's hope CI jobs will pass :)

[nvuillam]

thanks a lot @efrecon for your hardwork on this PR :)