Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add API descriptor with API_SPECTRAL with AsyncAPI/OpenAPI support #3474

Merged
merged 1 commit into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .automation/test/api/api_bad_1.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
openapi: '3.0.0'
3 changes: 3 additions & 0 deletions .automation/test/api/api_bad_2.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"openapi": "3.0.0"
}
13 changes: 13 additions & 0 deletions .automation/test/api/api_good_1.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
openapi: 3.0.0
info:
title: Example
version: "1.0"
contact:
name: Justin Kalland
email: [email protected]
description: Test for mega-linter
servers:
- url: "http://localhost:3000"
paths: {}
tags:
- name: example
23 changes: 23 additions & 0 deletions .automation/test/api/api_good_2.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"openapi": "3.0.0",
"info": {
"title": "Example",
"version": "1.0",
"contact": {
"name": "Justin Kalland",
"email": "[email protected]"
},
"description": "Test for mega-linter"
},
"servers": [
{
"url": "http://localhost:3000"
}
],
"paths": {},
"tags": [
{
"name": "example"
}
]
}
28 changes: 28 additions & 0 deletions .automation/test/api/reports/ERROR-API_SPECTRAL.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
Results of spectral linter (version 5.6.0)
See documentation on https://megalinter.io/descriptors/openapi_spectral/
-----------------------------------------------

[ERROR] .automation/test/api/api_bad_1.yml
OpenAPI 3.x detected

.automation/test/api/api_bad_1.yml
1:1 warning info-contact Info object should contain `contact` object.
1:1 warning info-description OpenAPI object info `description` must be present and non-empty string.
1:1 warning oas3-api-servers OpenAPI `servers` must be present and non-empty array.
1:1 error oas3-schema Object should have required property `info`.
1:1 warning openapi-tags OpenAPI object should have non-empty `tags` array.

✖ 5 problems (1 error, 4 warnings, 0 infos, 0 hints)

[ERROR] .automation/test/api/api_bad_2.json
OpenAPI 3.x detected

.automation/test/api/api_bad_2.json
1:1 warning info-contact Info object should contain `contact` object.
1:1 warning info-description OpenAPI object info `description` must be present and non-empty string.
1:1 warning oas3-api-servers OpenAPI `servers` must be present and non-empty array.
1:1 error oas3-schema Object should have required property `info`.
1:1 warning openapi-tags OpenAPI object should have non-empty `tags` array.

✖ 5 problems (1 error, 4 warnings, 0 infos, 0 hints)

12 changes: 12 additions & 0 deletions .automation/test/api/reports/SUCCESS-API_SPECTRAL.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Results of spectral linter (version 5.6.0)
See documentation on https://megalinter.io/descriptors/api_spectral/
-----------------------------------------------

[SUCCESS] .automation/test/api/api_good_1.yml
OpenAPI 3.x detected
No results with a severity of 'error' or higher found!

[SUCCESS] .automation/test/api/api_good_2.json
OpenAPI 3.x detected
No results with a severity of 'error' or higher found!

12 changes: 12 additions & 0 deletions .automation/test/api/reports/expected-API.tap
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
TAP version 13
1..4
not ok 1 - api_bad_1.yml
---
message: OpenAPI 3.x detected\n\n/tmp/lint/.automation/test/api/api_bad_1.ymlopenapi\n 1 1 warning info-contact Info object should contain `contact` object.\n 1 1 warning info-description OpenAPI object info `description` must be present and non-empty string.\n 1 1 warning oas3-api-servers OpenAPI `servers` must be present and non-empty array.\n 1 1 error oas3-schema Object should have required property `info`.\n 1 1 warning openapi-tags OpenAPI object should have non-empty `tags` array.\n\n✖ 5 problems (1 error, 4 warnings, 0 infos, 0 hints)\n
...
not ok 2 - api_bad_2.json
---
message: OpenAPI 3.x detected\n\n/tmp/lint/.automation/test/api/api_bad_2.jsonopenapi\n 1 1 warning info-contact Info object should contain `contact` object.\n 1 1 warning info-description OpenAPI object info `description` must be present and non-empty string.\n 1 1 warning oas3-api-servers OpenAPI `servers` must be present and non-empty array.\n 1 1 error oas3-schema Object should have required property `info`.\n 1 1 warning openapi-tags OpenAPI object should have non-empty `tags` array.\n\n✖ 5 problems (1 error, 4 warnings, 0 infos, 0 hints)\n
...
ok 3 - api_good_1.yml
ok 4 - api_good_2.json
1 change: 1 addition & 0 deletions .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,7 @@
"asdict",
"ashokm",
"assignuser",
"asyncapi",
"autocorrect",
"autocrlf",
"autofix",
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/deploy-BETA-linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ jobs:
[
"action_actionlint",
"ansible_ansible_lint",
"api_spectral",
"arm_arm_ttk",
"bash_exec",
"bash_shellcheck",
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/deploy-DEV-linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
[
"action_actionlint",
"ansible_ansible_lint",
"api_spectral",
"arm_arm_ttk",
"bash_exec",
"bash_shellcheck",
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/deploy-RELEASE-linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ jobs:
[
"action_actionlint",
"ansible_ansible_lint",
"api_spectral",
"arm_arm_ttk",
"bash_exec",
"bash_shellcheck",
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Note: Can be used with `oxsecurity/megalinter@beta` in your GitHub Action mega-l
- Media

- New linters
- `API_SPECTRAL` was added as replacement for `OPENAPI_SPECTRAL` (deprecated), supporting AsyncAPI and OpenAPI by default. Uses Spectral's standard config file name `.spectral.yaml` instead of `.openapirc.yml` with a default config with rulesets for AsyncAPI and OpenAPI enabled. Fixes [#3387](https://github.com/oxsecurity/megalinter/issues/3387)

- Reporters

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ WORKDIR /node-deps
RUN npm --no-cache install --ignore-scripts --omit=dev \
@salesforce/cli \
typescript \
@stoplight/spectral-cli \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvuillam idea for improvement here: sort the required packages, to not have the order changed uselessly like here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% agreed, can be done in another PR :)

@coffeelint/cli \
jscpd \
stylelint \
Expand Down Expand Up @@ -241,7 +242,6 @@ RUN npm --no-cache install --ignore-scripts --omit=dev \
markdownlint-cli \
markdown-link-check \
markdown-table-formatter \
@stoplight/spectral-cli \
secretlint \
@secretlint/secretlint-rule-preset-recommend \
@secretlint/secretlint-formatter-sarif \
Expand Down
11 changes: 11 additions & 0 deletions TEMPLATES/.spectral.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---

#######################################
#######################################
## AsyncAPI and OpenAPI Linter rules ##
#######################################
#######################################

extends:
- spectral:asyncapi
- spectral:oas
39 changes: 39 additions & 0 deletions docs/descriptors/api.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
title: API linters in MegaLinter
description: spectral is available to analyze API files in MegaLinter
---
<!-- markdownlint-disable MD003 MD020 MD033 MD041 -->
<!-- @generated by .automation/build.py, please don't update manually -->
<!-- Instead, update descriptor file at https://github.com/oxsecurity/megalinter/tree/main/megalinter/descriptors/api.yml -->
# API

## Linters

| Linter | Additional |
|-----------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------|
| [**spectral**](api_spectral.md)<br/>[_API_SPECTRAL_](api_spectral.md) | [![GitHub stars](https://img.shields.io/github/stars/stoplightio/spectral?cacheSeconds=3600)](https://github.com/stoplightio/spectral) |

## Linted files

- File extensions:
- `.yml`
- `.yaml`
- `.json`

- Detected file content:
- `"asyncapi":`
- `"openapi":`
- `"swagger":`
- `asyncapi:`
- `openapi:`
- `swagger:`

## Configuration in MegaLinter

| Variable | Description | Default value |
|--------------------------|-------------------------------------------------|---------------|
| API_PRE_COMMANDS | List of bash commands to run before the linters | None |
| API_POST_COMMANDS | List of bash commands to run after the linters | None |
| API_FILTER_REGEX_INCLUDE | Custom regex including filter | |
| API_FILTER_REGEX_EXCLUDE | Custom regex excluding filter | |

Loading