enhancement: Added missing XMLLINT schema properties #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyE123
requested review from
nvuillam,
echoix,
bdovaz and
Kurt-von-Laven
as code owners
echoix
approved these changes
Jun 21, 2024
|
@TommyE123 please can you share your linkedin ? :) I like to mention contributors in the posts i make for each release, and with all your contributions you deserve a BIG mention :) If you prefer to remain anonymous, that's ok too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simply adds the 2 missing properties to the json schema which are not added automatically when running
bash build.sh --doc.XML_XMLLINT_AUTOFORMATXML_XMLLINT_INDENTI’ve checked the ordering by running
bash build.sh --doconce added and they are correctly placed to not shuffle about on subsequent runs.