Fix: PMD sarif report preview unavailable. #4571
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [GitHub documentation](https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#specifying-the-location-for-source-files), the conversion of absolute URIs to relative URIs for the source root when uploading a SARIF report should not include the `file://` scheme.
xezzon
requested review from
nvuillam,
echoix,
bdovaz and
Kurt-von-Laven
as code owners
|
Remember that Megalinter is running in a docker image, and the workspace is mounted into it, so it isn't running directly from the GitHub runner |
nvuillam
requested changes
Jan 24, 2025
| @@ -96,6 +96,7 @@ def produce_report(self): | |||
| os.remove(linter.sarif_output_file) | |||
| result_json = json.dumps(sarif_obj, sort_keys=True, indent=4) | |||
| # Remove workspace prefix from file names | |||
| result_json = result_json.replace("file:///github/workspace", "") | |||
There was a problem hiding this comment.
What does replaceAll mean? Putting file:///github/workspace/d' into LIST_OF_REPLACEMENTS`?
Removing the I can't think of any other way to fix #4522 without incompatible changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the GitHub documentation, the conversion of absolute URIs to relative URIs for the source root when uploading a SARIF report should not include the
file://scheme.Fixes #4522
Proposed Changes
file:///github/workspaceto empty string for SARIF report before replacing/github/workspace.Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance