Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow commonjs config file for eslint #629

Merged
merged 6 commits into from
Aug 9, 2021

Conversation

vitaliytv
Copy link
Contributor

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@vitaliytv vitaliytv requested a review from nvuillam as a code owner August 7, 2021 13:03
@vitaliytv
Copy link
Contributor Author

proof

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your contribution !
Please can you update CHANGELOG.md ? :)

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2021

Codecov Report

Merging #629 (d184d54) into master (f964e7b) will increase coverage by 0.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   86.68%   87.67%   +0.98%     
==========================================
  Files         130      130              
  Lines        3034     3034              
==========================================
+ Hits         2630     2660      +30     
+ Misses        404      374      -30     
Impacted Files Coverage Δ
megalinter/MegaLinter.py 90.06% <0.00%> (+2.24%) ⬆️
megalinter/reporters/UpdatedSourcesReporter.py 89.18% <0.00%> (+2.70%) ⬆️
...alinter/tests/test_megalinter/helpers/utilstest.py 97.07% <0.00%> (+9.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bdccd...d184d54. Read the comment docs.

@nvuillam nvuillam merged commit 5371dba into oxsecurity:master Aug 9, 2021
@nvuillam
Copy link
Member

nvuillam commented Aug 9, 2021

I updated myself the changelog and merged the PR, thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants