Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tflint #649

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Upgrade tflint #649

merged 1 commit into from
Aug 14, 2021

Conversation

nvuillam
Copy link
Member

  • Upgrade tflint descriptor to use ghcr.io/terraform-linters/tflint docker image and initialize tflint

Closes #648

@nvuillam
Copy link
Member Author

nvuillam commented Aug 13, 2021

Mega-Linter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.25s
✅ BASH shellcheck 6 0 0.53s
✅ BASH shfmt 6 0 0 0.27s
✅ COPYPASTE jscpd yes no 2.58s
✅ CREDENTIALS secretlint yes no 4.33s
✅ CSS stylelint 1 0 0 1.16s
✅ DOCKERFILE dockerfilelint 1 0 0.29s
✅ DOCKERFILE hadolint 1 0 1.53s
✅ GIT git_diff yes no 0.03s
✅ JSON eslint-plugin-jsonc 19 0 0 4.72s
✅ JSON jsonlint 19 0 6.18s
✅ JSON v8r 19 0 14.28s
✅ MARKDOWN markdownlint 190 2 0 4.86s
✅ MARKDOWN markdown-link-check 190 0 89.45s
✅ MARKDOWN markdown-table-formatter 190 2 0 3.8s
✅ OPENAPI spectral 1 0 1.44s
⚠️ PYTHON bandit 137 1 2.3s
✅ PYTHON black 137 0 0 38.27s
✅ PYTHON flake8 137 0 2.44s
✅ PYTHON isort 137 0 0 0.35s
✅ PYTHON mypy 137 0 62.23s
✅ PYTHON pylint 137 0 14.64s
✅ SPELL cspell 468 0 37.28s
✅ SPELL misspell 317 2 0 0.31s
✅ XML xmllint 2 0 0.1s
✅ YAML prettier 89 0 0 52.79s
✅ YAML v8r 33 0 35.09s
✅ YAML yamllint 90 0 14.37s

See errors details in artifact Mega-Linter reports on GitHub Action page

You could have the same capabilities but better runtime performances if you use a Mega-Linter flavor:

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #649 (25e8622) into master (46d3efc) will increase coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   86.89%   87.68%   +0.78%     
==========================================
  Files         132      132              
  Lines        3044     3044              
==========================================
+ Hits         2645     2669      +24     
+ Misses        399      375      -24     
Impacted Files Coverage Δ
megalinter/MegaLinter.py 88.06% <0.00%> (+0.32%) ⬆️
megalinter/reporters/UpdatedSourcesReporter.py 89.18% <0.00%> (+2.70%) ⬆️
...alinter/tests/test_megalinter/helpers/utilstest.py 99.16% <0.00%> (+9.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d3efc...25e8622. Read the comment docs.

- Upgrade tflint descriptor to use ghcr.io/terraform-linters/tflint docker image and initialize tflint
@nvuillam nvuillam force-pushed the dependencies/tflint branch from 7012b57 to 25e8622 Compare August 14, 2021 01:28
@nvuillam nvuillam enabled auto-merge (squash) August 14, 2021 02:12
@nvuillam nvuillam merged commit d55e107 into master Aug 14, 2021
@nvuillam nvuillam deleted the dependencies/tflint branch August 14, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tflint --init is not run prior to tflint execution
2 participants