Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated REDIS_READY_PATTERN to match more Redis versions #3

Merged
merged 1 commit into from
May 15, 2018

Conversation

AndyWilks79
Copy link

Updated REDIS_READY_PATTERN to match more versions of Redis. Since version 4.0.* the final startup statement has changed, embedded Redis loops forever when it does not match the expected pattern. Proposed regex modification matches versions included with embedded-redis and versions 3.0.* and 4.0.*

Updated REDIS_READY_PATTERN to match more versions of Redis. Since version 4.0.* the final startup statement has changed, embedded Redis loops forever when it does not match the expected pattern.
@codecov-io
Copy link

Codecov Report

Merging #3 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #3      +/-   ##
============================================
+ Coverage     70.31%   70.65%   +0.33%     
  Complexity      111      111              
============================================
  Files            20       20              
  Lines           502      501       -1     
  Branches         38       38              
============================================
+ Hits            353      354       +1     
+ Misses          128      126       -2     
  Partials         21       21
Impacted Files Coverage Δ Complexity Δ
src/main/java/redis/embedded/RedisServer.java 56.52% <ø> (ø) 5 <0> (ø) ⬇️
.../main/java/redis/embedded/RedisClusterBuilder.java 89.04% <0%> (-0.15%) 19% <0%> (ø)
...ain/java/redis/embedded/AbstractRedisInstance.java 83.33% <0%> (+3.33%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa0874...8b2206b. Read the comment docs.

@robertotru robertotru merged commit 8452570 into ozimov:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants