Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The amount of data shown on mouseover popup is too little in some cases (example) #880

Closed
2 tasks done
valynor opened this issue Sep 18, 2024 · 8 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@valynor
Copy link

valynor commented Sep 18, 2024

Before Submitting Your Bug Report

  • I have verified that there isn't already an issue reporting the same bug to prevent duplication.
  • I have seen the FAQ.

Maccy Version (see 'About' window)

2.00

macOS Version

15.0

Maccy Settings

defaults read org.p0deje.Maccy
{
    "KeyboardShortcuts_delete" = "{\\"carbonModifiers\\":2048,\\"carbonKeyCode\\":51}";
    "KeyboardShortcuts_pin" = "{\\"carbonModifiers\\":2048,\\"carbonKeyCode\\":35}";
    "KeyboardShortcuts_popup" = "{\\"carbonModifiers\\":768,\\"carbonKeyCode\\":8}";
    "LaunchAtLogin__hasMigrated" = 1;
    "NSStatusItem Preferred Position Item-0" = 260;
    "NSStatusItem Visible Item-1" = 0;
    "NSWindow Frame SUStatusFrame" = "760 781 400 134 0 0 1920 1175 ";
    "NSWindow Frame SUUpdateAlert" = "970 762 620 398 0 0 2560 1415 ";
    "NSWindow Frame com.sindresorhus.Preferences.FrameAutosaveName" = "696 509 542 435 0 0 1920 1175 ";
    "NSWindow Frame com.sindresorhus.Settings.FrameAutosaveName" = "1025 719 510 473 0 0 2560 1415 ";
    SUEnableAutomaticChecks = 1;
    SUHasLaunchedBefore = 1;
    SULastCheckTime = "2024-09-18 13:01:33 +0000";
    SUUpdateGroupIdentifier = 3935178220;
    WebKitDefaultFontSize = 13;
    WebKitJavaEnabled = 0;
    WebKitJavaScriptEnabled = 0;
    WebKitPluginsEnabled = 0;
    WebKitStandardFont = "-apple-system-font";
    WebKitUserStyleSheetEnabledPreferenceKey = 1;
    WebKitUserStyleSheetLocationPreferenceKey = "/Applications/Maccy.app/Contents/Frameworks/Sparkle.framework/Resources/ReleaseNotesColorStyle.css";
    enabledPasteboardTypes =     (
        "public.file-url",
        "public.tiff",
        "public.rtf",
        "public.utf8-plain-text",
        "public.html",
        "public.png"
    );
    highlightMatch = color;
    history = {length = 42, bytes = 0x62706c69 73743030 a0080000 00000000 ... 00000000 00000009 };
    historySize = 100;
    ignoreEvents = 0;
    ignoreOnlyNextEvent = 0;
    ignoredPasteboardTypes =     (
        "Pasteboard generator type",
        "de.petermaurer.TransientPasteboardType",
        "com.agilebits.onepassword",
        "com.typeit4me.clipping",
        "net.antelle.keeweb"
    );
    menuIcon = clipboard;
    migrations =     {
        "2024-07-01-version-2" = 1;
    };
    numberOfUsages = 1;
    pinTo = top;
    playSounds = 0;
    popupPosition = center;
    previewDelay = 750;
    searchMode = mixed;
    showFooter = 1;
    showSearch = 1;
    showTitle = 0;
    windowPosition = "[0.9107421875,1]";
    windowSize = "[459,1411]";
}

Description

As you can see from the screenshot below Maccy doesn't show the full text copied in its popup.
When I copied the requested Maccy Settings above it DOES show all of the text in the popup though - seems to be dependent on the source.

Screenshot 2024-09-18 at 14 57 01
https://www.theguardian.com/world/2024/sep/17/photo-titan-submersible-wreckage

@valynor valynor added the bug Something isn't working label Sep 18, 2024
@p0deje
Copy link
Owner

p0deje commented Oct 2, 2024

Please try in 2.1.0, here is how it looks for me
Screenshot 2024-10-02 at 08 30 51

@p0deje p0deje closed this as completed Oct 2, 2024
@valynor
Copy link
Author

valynor commented Oct 2, 2024

@p0deje

I tried again with the example above and I'm afraid it's exactly the same as before.

Could this be a resolution/UI scaling issue?
I'm using a 4K 3840x2160 32" display with UI scaling set like this:
Resolution: 5120x2880 (5K/UHD+ - Ultra High Definition Plus)
UI Looks like: 2560 x 1440 @ 144.00Hz

@p0deje
Copy link
Owner

p0deje commented Oct 2, 2024

@valynor I don't think it's related, can you please upload a new screenshot?

@valynor
Copy link
Author

valynor commented Oct 2, 2024

Screenshot 2024-10-02 at 19 20 07

Like I said, exactly the same.

Edit: When I copy the entire article the popup shows more text but still not the complete article.

@valynor
Copy link
Author

valynor commented Nov 23, 2024

@p0deje
Hi, displaying long text seems to be fixed now (thanks!) but URLs are still broken.

Example: Go to https://www.amazon.de/dp/B0DLBSF3PC/ and copy the URL from the toolbar.
In the Maccy popup it looks like this:

Screenshot 2024-11-23 at 03 31 38

There's really no reason to cut that already short URL like this IMHO ..?

Another example, if I copy the text above the picture in this post it looks like that:

Screenshot 2024-11-23 at 03 36 58

The "Example: ... looks like this:" part is completely missing.

@p0deje
Copy link
Owner

p0deje commented Nov 23, 2024

Yeah, this still needs improvement. The problem is that SwiftUI doesn't provide an easy solution for wrapping the text so hacky workarounds are necessary for now. I'll try to find a better way to do this.

p0deje added a commit that referenced this issue Nov 23, 2024
@p0deje
Copy link
Owner

p0deje commented Nov 23, 2024

Can you update to 2.2.1, it should be a bit better (though still not perfect)

@valynor
Copy link
Author

valynor commented Nov 23, 2024

Updated, much better now. Even very long links wrap nicely and show completely now. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants