Change the default behavior of selecting default configurations #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I noticed that current init process requires an explicit parameter to use YAML config.
Therefore, to allow usage of YAML as default config, here is my proposal on this section that:
When user has explicitly specified a config using -config parameter:
When user has not explicitly specified:
My proposal will try three candidate:
config.json
,config.yml
, andconfig.yaml
.For each candidate:
err.Error()
), raise a warning that the file is not there and move to next candidate (line 40-42 and line 78); if anything else happened, raise a fatal exception is raised (line 44);There is one thing to do: I have no idea what OS X raise when a file is not found.
I am looking forward to your ideas and feedback.
Regards,
Chinese White Dolphin