Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use main branch P4C reference. #55

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Use main branch P4C reference. #55

merged 1 commit into from
Jan 28, 2025

Conversation

fruffy
Copy link
Contributor

@fruffy fruffy commented Jan 27, 2025

Fixes #46.

@fruffy fruffy requested a review from jafingerhut January 27, 2025 22:37
jafingerhut
jafingerhut approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how in Github's PR GUI to see which commit SHA of p4lang/p4c this is pointing at, but I'm happy to approve, merge it in, and try it out.

@fruffy fruffy merged commit 9bba1f0 into main Jan 28, 2025
3 checks passed
@fruffy fruffy deleted the fruffy/correct_p4c branch January 28, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p4c submodule points at commit that Github warns is not part of any branch of p4c, and might be part of a fork
2 participants
@fruffy @jafingerhut