Fix for the issue when number of error values is more than 9 (#1824) #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the way error code value is generated in bmv2 backend. Instead of decimal value, it is generated as hex value into json file (issue p4lang#1824) Signed-off-by: Enisa Hadzic <[email protected]>
mihaibudiu
approved these changes
Mar 26, 2019
There was a problem hiding this comment.
This was originally part of #1799. There is a discussion there about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the way error code value is generated in bmv2 backend.
Instead of decimal value, it is generated as hex value into json file
(issue #1824)
Signed-off-by: Enisa Hadzic [email protected]