Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rules that require a cpp toolchain to use a helper function th… #3401

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Update rules that require a cpp toolchain to use a helper function th… #3401

merged 1 commit into from
Jun 22, 2022

Conversation

katre
Copy link
Contributor

@katre katre commented Jun 22, 2022

…at defines the toolchain type.

@smolkaj
Copy link
Member

smolkaj commented Jun 22, 2022

Thanks, LGTM.

@katre
Copy link
Contributor Author

katre commented Jun 22, 2022

All tests pass, can this be merged? Thanks

@mihaibudiu mihaibudiu merged commit 2645f65 into p4lang:main Jun 22, 2022
@katre katre deleted the patch-1 branch June 22, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katre @smolkaj @mihaibudiu