Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML formatting from Redhead YAML language server. #4521

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Mar 12, 2024

@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Mar 12, 2024
Copy link
Contributor

@vlstill vlstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Is there any plan to automatically check the formatting, or is that not worth the work? My guess is we can do it later if we have more modifations of these files breaking the format.

Base automatically changed from fruffy/mac_os_fixes to main March 12, 2024 13:10
@fruffy fruffy force-pushed the fruffy/ci_yaml_formatting branch from 08bbeb3 to d0f4cec Compare March 12, 2024 14:43
@fruffy
Copy link
Collaborator Author

fruffy commented Mar 12, 2024

Is there any plan to automatically check the formatting, or is that not worth the work?

Did not plan for it right now. This was just a spontaneous fixup because I was editing the YAML files and noticed the indentation/formatting was off. Our linting run is fast, it should not be too difficult to add.

Edit: Looks like the formatter requires prettier installed, which seems like a bit too big of a dependency to me.

@fruffy fruffy marked this pull request as ready for review March 12, 2024 15:26
@fruffy fruffy enabled auto-merge March 12, 2024 15:26
@fruffy fruffy added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 5730c63 Mar 12, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/ci_yaml_formatting branch March 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants