Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 'make check' more consistent (and better documented) across all projects #579

Closed
bcrocker15 opened this issue Apr 30, 2021 · 0 comments · Fixed by #566 or #593
Closed

Make 'make check' more consistent (and better documented) across all projects #579

bcrocker15 opened this issue Apr 30, 2021 · 0 comments · Fixed by #566 or #593
Assignees
@bcrocker15

Comments

@bcrocker15
Copy link
Contributor

We need to make 'make check' more consistent (and better documented) across all projects:
packit
packit-service
ogr
sandcastle
deployment
@bcrocker15 bcrocker15 linked a pull request May 5, 2021 that will close this issue
Make 'make check' more consistent, and better documented, across projects #566
Merged
@bcrocker15 bcrocker15 mentioned this issue May 5, 2021
Merged
bcrocker15 added a commit to bcrocker15/ogr that referenced this issue May 5, 2021
@bcrocker15
Makefile:
f339c39 
Abolish the 'prepare-check' target, merging its functionality into
'check' target.  In 'check' target, conditionally install

- python3-flexmock
- python3-requre

depending on presence/absence of /usr/share/doc/python3-flexmock
and /usr/bin/requre-patch respectively.

Check for

- ansible-bender
- podman

in 'build' target.

Remove all mention of unused python3-tox.

CONTRIBUTING.md:

Remove all mention of unused tox.

Remove mention of prepare-check (merged into 'check' target).
Document installation of python3-flexmock and python3-requre
by 'make check', ansible-bender and podman by 'make build'.

Include note about 7.1 GB of disk space consumed by 'make build'.

Mention conditional installation of

- ansible-bender
- podman
- python3-requre
- python3-flexmock

Minor language & spelling fixes.

Fixes OGR issue packit#579

Signed-off-by: Ben Crocker <[email protected]>
@bcrocker15 bcrocker15 self-assigned this May 5, 2021
bcrocker15 added a commit to bcrocker15/ogr that referenced this issue May 10, 2021
@bcrocker15
Makefile:
bfb3af2 
Introduce IS_FEDORA to record whether we're building on Fedora,
and to introduce a model for conditionalizing on OS; introduce
PACKAGE_CHECKER to check for presence of package, and
PACKAGE_INSTALLER to install a package.

Abolish the 'prepare-check' target, merging its functionality into
'check' target.  In 'check' target, conditionally install

- python3-flexmock
- python3-requre

depending on presence/absence of /usr/share/doc/python3-flexmock
and /usr/bin/requre-patch respectively.

Check for

- ansible-bender
- podman

in 'build' target.

Remove all mention of unused python3-tox.

CONTRIBUTING.md:

Remove all mention of unused tox.

Remove mention of prepare-check (merged into 'check' target).
Document installation of python3-flexmock and python3-requre
by 'make check', ansible-bender and podman by 'make build'.

Include note about 7.1 GB of disk space consumed by 'make build'.

Mention conditional installation of

- ansible-bender
- podman
- python3-requre
- python3-flexmock

Minor language & spelling fixes.

Fixes OGR issue packit#579

Signed-off-by: Ben Crocker <[email protected]>
bcrocker15 added a commit to bcrocker15/ogr that referenced this issue May 11, 2021
@bcrocker15
Makefile:
1960705 
Introduce IS_FEDORA to record whether we're building on Fedora,
and to introduce a model for conditionalizing on OS; introduce
PACKAGE_CHECKER to check for presence of package, and
PACKAGE_INSTALLER to install a package.

In 'prepare-check' target, check for and conditionally install:

- python3-flexmock
- python3-requre

depending on presence/absence of /usr/share/doc/python3-flexmock
and /usr/bin/requre-patch respectively.

Introduce 'prepare-build' target, check for and conditionally
install:

- ansible-bender
- podman

in 'build' target.

Remove all mention of unused python3-tox.

CONTRIBUTING.md:

Remove all mention of unused tox.

Remove mention of prepare-check (merged into 'check' target).
Document installation of python3-flexmock and python3-requre
by 'make check', ansible-bender and podman by 'make build'.

Include note about 7.1 GB of disk space consumed by 'make build'.

Mention conditional installation of

- ansible-bender
- podman
- python3-requre
- python3-flexmock

Minor language & spelling fixes.

Fixes OGR issue packit#579

Signed-off-by: Ben Crocker <[email protected]>
bcrocker15 added a commit to bcrocker15/ogr that referenced this issue May 12, 2021
@bcrocker15
Makefile:
ab13c63 
Introduce IS_FEDORA to record whether we're building on Fedora,
and to introduce a model for conditionalizing on OS; introduce
PACKAGE_CHECKER to check for presence of package, and
PACKAGE_INSTALLER to install a package.

In 'prepare-check' target, check for and conditionally install:

- python3-flexmock
- python3-requre

depending on presence/absence of /usr/share/doc/python3-flexmock
and /usr/bin/requre-patch respectively.

Introduce 'prepare-build' target, check for and conditionally
install:

- ansible-bender
- podman

in 'build' target.

Remove all mention of unused python3-tox.

CONTRIBUTING.md:

Remove all mention of unused tox.

Document installation of python3-flexmock and python3-requre by
'make prepare-check', ansible-bender and podman by 'make prepare-build'.

Include note about 7.1 GB of disk space consumed by 'make build'.

Mention conditional installation of

- ansible-bender
- podman
- python3-requre
- python3-flexmock

Minor language & spelling fixes.

Fixes OGR issue packit#579

Signed-off-by: Ben Crocker <[email protected]>
bcrocker15 added a commit to bcrocker15/ogr that referenced this issue May 14, 2021
@bcrocker15
Makefile:
5fd32ed 
Introduce IS_FEDORA to record whether we're building on Fedora,
and to introduce a model for conditionalizing on OS; introduce
PACKAGE_CHECKER to check for presence of package, and
PACKAGE_INSTALLER to install a package.

In 'prepare-check' target, check for and conditionally install:

- python3-flexmock
- python3-requre

depending on presence/absence of /usr/share/doc/python3-flexmock
and /usr/bin/requre-patch respectively.

Introduce 'prepare-build' target, check for and conditionally
install:

- ansible-bender
- podman

in 'build' target.

Remove all mention of unused python3-tox.

CONTRIBUTING.md:

Remove all mention of unused tox.

Document installation of python3-flexmock and python3-requre by
'make prepare-check', ansible-bender and podman by 'make prepare-build'.

Include note about multiple GB of disk space consumed by 'make build'.

Mention conditional installation of

- ansible-bender
- podman
- python3-requre
- python3-flexmock

Minor language & spelling fixes.

Fixes OGR issue packit#579

Signed-off-by: Ben Crocker <[email protected]>
bcrocker15 added a commit to bcrocker15/ogr that referenced this issue May 20, 2021
@bcrocker15
Makefile:
b834535 
Introduce IS_FEDORA to record whether we're building on Fedora,
and to introduce a model for conditionalizing on OS; introduce
PACKAGE_CHECKER to check for presence of package, and
PACKAGE_INSTALLER to install a package.

In 'prepare-check' target, check for and conditionally install:

- python3-flexmock
- python3-requre

depending on presence/absence of /usr/share/doc/python3-flexmock
and /usr/bin/requre-patch respectively.

Introduce 'prepare-build' target, check for and conditionally
install:

- ansible-bender
- podman

in 'build' target.

Remove all mention of unused python3-tox.

CONTRIBUTING.md:

Remove all mention of unused tox.

Document installation of python3-flexmock and python3-requre by
'make prepare-check', ansible-bender and podman by 'make prepare-build'.

Include note about multiple GB of disk space consumed by 'make build'.

Mention conditional installation of

- ansible-bender
- podman
- python3-requre
- python3-flexmock

Minor language & spelling fixes.

Fixes OGR issue packit#579

Signed-off-by: Ben Crocker <[email protected]>
softwarefactory-project-zuul bot added a commit that referenced this issue May 20, 2021
@softwarefactory-project-zuul
Merge pull request #566 from bcrocker15/ogr-makefile-update-prepare-c…
f1d906b 
…heck

Make 'make check' more consistent, and better documented, across projects

Makefile:
Abolish the 'prepare-check' target, merging its functionality into
'check' target.  In 'check' target, conditionally install

python3-flexmock
python3-requre

depending on presence/absence of /usr/share/doc/python3-flexmock
and /usr/bin/requre-patch respectively.
Check for

ansible-bender
podman

in 'build' target.
Remove all mention of unused python3-tox.
CONTRIBUTING.md:
Remove all mention of unused tox.
Remove mention of prepare-check (merged into 'check' target).
Document installation of python3-flexmock and python3-requre
by 'make check', ansible-bender and podman by 'make build'.
Include note about 7.1 GB of disk space consumed by 'make build'.
Mention conditional installation of

ansible-bender
podman
python3-requre
python3-flexmock

Minor language & spelling fixes.
Fixes #579

Reviewed-by: None <None>
Reviewed-by: None <None>
Reviewed-by: Hunor Csomortáni <[email protected]>
bcrocker15 added a commit to bcrocker15/ogr that referenced this issue May 27, 2021
@bcrocker15
Make 'make check' more consistent across projects
e27ad8a 
We have decided to remove the prepare-check and prepare-build
targets entirely, relying instead on strongly-worded recommendations
in CONTRIBUTING.md and README.md.

Fixes ogr issue packit#579.

Signed-off-by: Ben Crocker <[email protected]>
@bcrocker15 bcrocker15 mentioned this issue May 27, 2021
Merged
@bcrocker15 bcrocker15 linked a pull request May 28, 2021 that will close this issue
Make 'make check' more consistent across projects #593
Merged
bcrocker15 added a commit to bcrocker15/ogr that referenced this issue Jun 1, 2021
@bcrocker15
Make 'make check' more consistent across projects
ea2640e 
We have decided to remove the prepare-check and prepare-build
targets entirely, relying instead on strongly-worded recommendations
in CONTRIBUTING.md and README.md.

Fixes ogr issue packit#579.

Signed-off-by: Ben Crocker <[email protected]>
bcrocker15 added a commit to bcrocker15/ogr that referenced this issue Jun 2, 2021
@bcrocker15
Make 'make check' more consistent across projects
589e056 
We have decided to remove the prepare-check and prepare-build
targets entirely, relying instead on strongly-worded recommendations
in CONTRIBUTING.md and README.md.

Change 'build' target in Makefile to 'build-test-image'.

Emphasize testing in a container in CONTRIBUTING.md.

Fixes ogr issue packit#579.

Signed-off-by: Ben Crocker <[email protected]>
bcrocker15 added a commit to bcrocker15/ogr that referenced this issue Jun 3, 2021
@bcrocker15
Make 'make check' more consistent across projects
81012ea 
We have decided to remove the prepare-check and prepare-build
targets entirely, relying instead on strongly-worded recommendations
in CONTRIBUTING.md and README.md.

Change 'build' target in Makefile to 'build-test-image'.

Emphasize testing in a container in CONTRIBUTING.md.

Fixes ogr issue packit#579.

Signed-off-by: Ben Crocker <[email protected]>
softwarefactory-project-zuul bot added a commit that referenced this issue Jun 3, 2021
@softwarefactory-project-zuul
Merge pull request #593 from bcrocker15/2-ogr-issue-579
2742a57 
Make 'make check' more consistent across projects

We have decided to remove the prepare-check and prepare-build
targets entirely, relying instead on strongly-worded recommendations
in CONTRIBUTING.md and README.md.
Fixes ogr issue #579.
Signed-off-by: Ben Crocker [email protected]

Reviewed-by: Hunor Csomortáni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcrocker15 bcrocker15

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bcrocker15