Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property and raise specific exception when issues are disabled #664

Closed
7 tasks
lachmanfrantisek opened this issue Dec 10, 2021 · 1 comment · Fixed by #684
Closed
7 tasks

Add property and raise specific exception when issues are disabled #664

lachmanfrantisek opened this issue Dec 10, 2021 · 1 comment · Fixed by #684
Labels
area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. good-first-issue Good for newcomers. kind/feature New feature or a request for enhancement. pagure Related to Pagure implementation. stale Is the issue still valid?

Comments

@lachmanfrantisek
Copy link
Member

Related to this: packit/packit-service#457

Some repositories like https://github.com/rhinstaller/anaconda or all distgit repositories on Pagure (e.g. https://src.fedoraproject.org/rpms/packit/) have issues disabled. Let's provide some code to work with this more nicely:

TODO:

  • Create a project property to show if the project has issues disabled.
    • Add the property to the abstract Project class (without implementation).
    • Implement the property and add test for all the forges:
      • GitLab
      • GitHub
      • Pagure
  • Create an exception (or a structure of exceptions) to be raised when someone tries to create an issue on the project with a disabled issue tracker. (+ test this)
@lachmanfrantisek lachmanfrantisek added kind/feature New feature or a request for enhancement. good-first-issue Good for newcomers. area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. pagure Related to Pagure implementation. labels Dec 10, 2021
@lachmanfrantisek lachmanfrantisek mentioned this issue Dec 10, 2021
Closed
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Mar 2, 2022
mfocko added a commit to mfocko/ogr that referenced this issue Mar 10, 2022
@mfocko
feat: add property for issue tracker status
af86295 
Add property to GitProject class that denotes whether issue tracker is
enabled on the specific project or not.

Fixes packit#664

Signed-off-by: Matej Focko <[email protected]>
@mfocko mfocko mentioned this issue Mar 10, 2022
Merged
1 task
mfocko added a commit to mfocko/ogr that referenced this issue Mar 10, 2022
@mfocko
feat: add property for issue tracker status
5cbeffb 
Add property to GitProject class that denotes whether issue tracker is
enabled on the specific project or not.

Fixes packit#664

Signed-off-by: Matej Focko <[email protected]>
mfocko added a commit to mfocko/ogr that referenced this issue Mar 18, 2022
@mfocko
feat: add property for issue tracker status
e507818 
Add property to GitProject class that denotes whether issue tracker is
enabled on the specific project or not.

Fixes packit#664

Signed-off-by: Matej Focko <[email protected]>
softwarefactory-project-zuul bot added a commit that referenced this issue Mar 18, 2022
@softwarefactory-project-zuul
Merge pull request #684 from mfocko/has-issue
d04a107 
feat: add property for issue tracker status

Add property to GitProject class that denotes whether issue tracker is
enabled on the specific project or not.
Signed-off-by: Matej Focko [email protected]
TODO:

 finish it off with the exception for disabled issue tracker

Fixes #664
RELEASE NOTES BEGIN
We have added a new property to git projects has_issues that indicates whether project has enabled issues or not. Following up on the property, create_issue now raises IssueTrackerDisabled when the project doesn't have issues enabled.
RELEASE NOTES END

Reviewed-by: None <None>
Reviewed-by: Tomas Tomecek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. good-first-issue Good for newcomers. kind/feature New feature or a request for enhancement. pagure Related to Pagure implementation. stale Is the issue still valid?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add property for issue tracker status mfocko/ogr
1 participant
@lachmanfrantisek