Support using the merge ref instead of the head ref in a pull request #601

bcrocker15 · 2021-06-13T01:06:19Z

Add merge_commit_sha and mergeable properties to GithubPullRequest class
(and PullRequest superclass).

OGR issue #584.

Signed-off-by: Ben Crocker [email protected]

softwarefactory-project-zuul · 2021-06-13T01:29:48Z

Build succeeded.

pre-commit : SUCCESS in 3m 52s
ogr-tests-rpm : SUCCESS in 2m 10s
ogr-tests-pip-deps : SUCCESS in 2m 06s
ogr-reverse-dep-packit-tests : SUCCESS in 22m 32s

TomasTomecek

so far so good! can we have this for gitlab as well? tests would be very much appreciated here :)

TomasTomecek · 2021-06-14T09:08:03Z

ogr/abstract.py

@@ -404,6 +404,14 @@ def patch(self) -> bytes:
    def head_commit(self) -> str:
        raise NotImplementedError

+    @property
+    def merge_commit_sha(self) -> str:
+        raise NotImplementedError


Suggested change

raise NotImplementedError

raise NotImplementedError()

an instance should be raised instead of the class

It does not matter, you can use class or and instance: https://docs.python.org/3/reference/simple_stmts.html#the-raise-statement :

raise evaluates the first expression as the exception object. It must be either a subclass or an instance of BaseException. If it is a class, the exception instance will be obtained when needed by instantiating the class with no arguments.

(discussion: https://stackoverflow.com/questions/16706956/is-there-a-difference-between-raise-exception-and-raise-exception-without#16709222)

I know it works but this was the first time I've checked it in the docs..;) So, thanks for pointing that out!

But it would be nice to unify this across the project.

As I mentioned on IRC, in GitHub, 'mergeable' is a boolean, while in
GitLab, the closest thing seems to be merge_status which, if I'm
reading the doc (https://docs.gitlab.com/ee/api/merge_requests.html)
correctly, is a string that can have several values including "unchecked",
"checking", "can_be_merged", and "cannot_be_merged".

I went on to say that "...Maybe the answer is to map GL's
"can_be_merged" to 'True' and everything else to 'False'" and Tomas
like this idea, at least provisionally.

OR we could map "can_be_merged" to True, "cannot_be_merged" to False,
and everything else to None.

In the Packit Arthitecture meeting on 06/15/2021, we decided that we
would present GitLab-like behavior, and map GitHub behavior onto it.

This means that we will provide a (GitLab-like) 'merge_status' @Property
instead of (GitHub-like) 'mergeable', with GitHub's
'mergeable' values mapped as follows:

mergeable => merge_status

True "can_be_merged"

False "cannot_be_merged"

<> "unchecked"

<> "checking"

<> "cannot_be_merged_recheck"

softwarefactory-project-zuul · 2021-06-14T16:02:49Z

Build succeeded.

pre-commit : SUCCESS in 3m 32s
ogr-tests-rpm : SUCCESS in 2m 04s
ogr-tests-pip-deps : SUCCESS in 2m 12s
ogr-reverse-dep-packit-tests : SUCCESS in 18m 10s

mfocko · 2021-06-15T14:44:23Z

ogr/services/github/pull_request.py

-        return self._raw_pr.mergeable
+    def merge_status(self) -> str:
+        if self._raw_pr.mergeable:
+            return "can_be_merged"


I thought you meant an enumeration like this for commit statuses.

agreed, an enum here would be much better

softwarefactory-project-zuul · 2021-06-15T15:36:36Z

Build failed.

pre-commit : SUCCESS in 4m 55s
ogr-tests-rpm : NODE_FAILURE in 0s
ogr-tests-pip-deps : SUCCESS in 2m 21s
ogr-reverse-dep-packit-tests : SUCCESS in 23m 24s

softwarefactory-project-zuul · 2021-06-17T02:04:58Z

Build failed.

pre-commit : SUCCESS in 3m 46s
ogr-tests-rpm : FAILURE in 2m 13s
ogr-tests-pip-deps : FAILURE in 3m 27s
ogr-reverse-dep-packit-tests : SUCCESS in 23m 21s

bcrocker15 · 2021-06-17T02:44:54Z

On my last run, I got some errors that I do not understand:

E OSError: You are in Requre write mode, please set proper GITHUB_TOKEN env variables

See below.

I have a GITHUB_TOKEN defined in my environment (set in ~/.bashrc);
I do not understand why these errors are cropping up in the new
test_merge_commit_sha_* methods I just introduced, and not in the very
similar test_head_commit method on which I modeled test_merge_commit_sha_*.

____________________ PullRequests.test_merge_commit_sha_240 ____________________

self = <tests.integration.github.test_pull_requests.PullRequests testMethod=test_merge_commit_sha_240>

def setUp(self):
    super().setUp()
    self.token = os.environ.get("GITHUB_TOKEN")
    if not Path(get_datafile_filename(obj=self)).exists() and not self.token:

      raise EnvironmentError(

            "You are in Requre write mode, please set proper GITHUB_TOKEN env variables"
        )

E OSError: You are in Requre write mode, please set proper GITHUB_TOKEN env variables

class = <class 'tests.integration.github.base.GithubTests'>
self = <tests.integration.github.test_pull_requests.PullRequests testMethod=test_merge_commit_sha_240>

bcrocker15 · 2021-06-17T02:50:57Z

I expect that, once we get the aforementioned issues and errors straightened out,
I'll be able to write some tests for GitLab and Pagure, as well.

BTW, 'make check' takes about 10 minutes in my experience; less if the test domain
is restricted by, e.g.,

%%% TEST_TARGET=./tests/integration/github/ make check

jscotka · 2021-06-17T10:09:37Z

@bcrocker15 Hi Ben,
I've investigated that we've made issue inside requre project when reworking decorators.
Bad was that it affected just write mode of requre, so that we was not able to catch it by reverse dependency testing.
last working commit hash of requre is: 0dbd6ca8899bb3e0fda72363f03bfe0adb4b19db
so you can try it to regenerate it via installing requre to this commit or I can do it for you. But it would be better if you try it as well to prove that my investigation is right. (just ensure that you have just one installation (user or system or requre, to aovid situation that you install this commit hash version, but finally requre will be used from another location.))

EDIT: issue is more complicated and causing, that currently tests does not test anything and there may be false negative results and may hide regressions (see: https://github.com/packit/requre/pull/206/files#diff-013a26cea674b9569659c20d86db214c9d25108da1a8c54c5bab6a265a442619R64 )
have to fix the issue as soon as possible inside requre project. with @lachmanfrantisek working on that.

softwarefactory-project-zuul · 2021-06-17T21:24:51Z

Build failed.

pre-commit : SUCCESS in 3m 47s
ogr-tests-rpm : FAILURE in 2m 19s
ogr-tests-pip-deps : FAILURE in 2m 15s
ogr-reverse-dep-packit-tests : SUCCESS in 24m 38s

bcrocker15 · 2021-06-18T01:20:05Z

I'm anticipating a question like, "Why didn't I combine all my
test_merge_commit_sha_* methods into a single method that looks
like this:

def test_merge_commit_sha_240(self):
    pr240 = self.hello_world_project.get_pr(240)
    pr111 = self.hello_world_project.get_pr(111)
    pr112 = self.hello_world_project.get_pr(112)
    assert pr240.head_commit == "dabfd3862702e49b6877da7f224e6d6458eb961a"
    assert pr240.merge_commit_sha == "f502aae6920d82948f2dba0b70c9260fb1e34822"
    assert pr240.merge_status == "cannot_be_merged"  # Because it's already merged
    assert pr111.head_commit == "1abb19255a7c1bec7ffcae2487f022b23175af2b"
    assert pr111.merge_commit_sha == "8512ef316918edc39c4a6eee13e6cc45344d03ac"
    assert pr111.merge_status == "cannot_be_merged"  # Conflicts
    assert pr112.head_commit == "9ab13fa4b4944510022730708045f42aea106cef"
    assert pr112.merge_commit_sha == "0dc8211e10e37370f49364495249f5c693a9eff7"
    # Not (yet) merged; good thing! (invalid specfile):
    assert pr112.merge_status == "can_be_merged"

The answer is that it appears to break pytest; I see this in the log (changed > to ->
below because > affects the formatting):

______________________ PullRequests.test_merge_commit_sha ______________________

self = <tests.integration.github.test_pull_requests.PullRequests testMethod=test_merge_commit_sha>

def test_merge_commit_sha(self):
    pr240 = self.hello_world_project.get_pr(240)

-> pr111 = self.hello_world_project.get_pr(111)

pr240 = <GithubPullRequest(title='testing-farm: migrate to official TMT format', id=240, status='merged', url='https://github....n='Not sure w...', author='thrix', source_branch='fix-fmf-tests', target_branch='main', created='2021-02-17 17:10:34')>
self = <tests.integration.github.test_pull_requests.PullRequests testMethod=test_merge_commit_sha>

...
followed, after about 170 lines of text, by

E requre.exceptions.ItemNotInStorage: Keys not in storage:/home/bcrocker/Work/packit-all/ogr/tests/integration/github/test_data/test_pull_requests/PullRequests.test_merge_commit_sha.yaml Matched: ['requests.sessions', 'send', 'GET'], Missing: ['https://api.github.com:443/repos/packit/hello-world/pulls/111']

jscotka · 2021-06-18T07:02:58Z

@bcrocker15 It can be combined together, it should no be any issue. Just be sure that when you do that. You have to regenerate the data files. because data file is connected with one test. so that In case you'll extend one test you have to regenerate the file.
so that in case your test contains eg. self.hello_world_project.get_pr(240) and you will add second call self.hello_world_project.get_pr(240) you have to regenerate file because it will there stored one times but extended test expect to have it there twice.

There is bigger reason why it is solved in this way: as example you can have command like with creating new PR

get pull requests count
create new PR
get pull requests count
see if count after create PR increased by one.

Another issue could be when you reorder commands calls (just in some cases), it may also lead to need of regenereate data (it depends on stored keys for the data and how data are sent to server) e.g. in case some requests to github differs (stored is HTTP method and URL) so that in case it differs just by sent data, it will be concatenated inside one list, so that in case you will change order of commands data will be server in reversed order.

And it seems that you've used old data file, beucase pr240 is there but pr11 is not stored there.

I'm anticipating a question like, "Why didn't I combine all my
test_merge_commit_sha_* methods into a single method that looks
like this:
def test_merge_commit_sha_240(self):
    pr240 = self.hello_world_project.get_pr(240)
    pr111 = self.hello_world_project.get_pr(111)
    pr112 = self.hello_world_project.get_pr(112)
    assert pr240.head_commit == "dabfd3862702e49b6877da7f224e6d6458eb961a"
    assert pr240.merge_commit_sha == "f502aae6920d82948f2dba0b70c9260fb1e34822"
    assert pr240.merge_status == "cannot_be_merged"  # Because it's already merged
    assert pr111.head_commit == "1abb19255a7c1bec7ffcae2487f022b23175af2b"
    assert pr111.merge_commit_sha == "8512ef316918edc39c4a6eee13e6cc45344d03ac"
    assert pr111.merge_status == "cannot_be_merged"  # Conflicts
    assert pr112.head_commit == "9ab13fa4b4944510022730708045f42aea106cef"
    assert pr112.merge_commit_sha == "0dc8211e10e37370f49364495249f5c693a9eff7"
    # Not (yet) merged; good thing! (invalid specfile):
    assert pr112.merge_status == "can_be_merged"
The answer is that it appears to break pytest; I see this in the log (changed > to ->
below because > affects the formatting):

______________________ PullRequests.test_merge_commit_sha ______________________

self = <tests.integration.github.test_pull_requests.PullRequests testMethod=test_merge_commit_sha>
def test_merge_commit_sha(self):
    pr240 = self.hello_world_project.get_pr(240)
-> pr111 = self.hello_world_project.get_pr(111)

pr240 = <GithubPullRequest(title='testing-farm: migrate to official TMT format', id=240, status='merged', url='https://github....n='Not sure w...', author='thrix', source_branch='fix-fmf-tests', target_branch='main', created='2021-02-17 17:10:34')>
self = <tests.integration.github.test_pull_requests.PullRequests testMethod=test_merge_commit_sha>

...
followed, after about 170 lines of text, by

E requre.exceptions.ItemNotInStorage: Keys not in storage:/home/bcrocker/Work/packit-all/ogr/tests/integration/github/test_data/test_pull_requests/PullRequests.test_merge_commit_sha.yaml Matched: ['requests.sessions', 'send', 'GET'], Missing: ['https://api.github.com:443/repos/packit/hello-world/pulls/111']

TomasTomecek

Looks good! Let's have the enum for the status and I believe we're good to go

TomasTomecek · 2021-06-18T15:22:47Z

ogr/services/github/pull_request.py

-        return self._raw_pr.mergeable
+    def merge_status(self) -> str:
+        if self._raw_pr.mergeable:
+            return "can_be_merged"


agreed, an enum here would be much better

softwarefactory-project-zuul · 2021-06-19T01:16:36Z

Build failed.

pre-commit : SUCCESS in 3m 27s
ogr-tests-rpm : FAILURE in 7m 31s
ogr-tests-pip-deps : FAILURE in 6m 41s
ogr-reverse-dep-packit-tests : SUCCESS in 24m 26s

softwarefactory-project-zuul · 2021-06-19T02:16:47Z

Build failed.

pre-commit : SUCCESS in 3m 18s
ogr-tests-rpm : FAILURE in 6m 24s
ogr-tests-pip-deps : FAILURE in 6m 19s
ogr-reverse-dep-packit-tests : SUCCESS in 22m 17s

softwarefactory-project-zuul · 2021-06-19T03:04:27Z

Build failed.

pre-commit : SUCCESS in 3m 06s
ogr-tests-rpm : FAILURE in 7m 17s
ogr-tests-pip-deps : FAILURE in 6m 47s
ogr-reverse-dep-packit-tests : SUCCESS in 23m 32s

softwarefactory-project-zuul · 2021-06-19T18:40:51Z

Build failed.

pre-commit : SUCCESS in 3m 34s
ogr-tests-rpm : FAILURE in 8m 18s
ogr-tests-pip-deps : FAILURE in 8m 16s
ogr-reverse-dep-packit-tests : SUCCESS in 23m 16s

softwarefactory-project-zuul · 2021-06-19T19:30:50Z

Build failed.

pre-commit : SUCCESS in 3m 52s
ogr-tests-rpm : FAILURE in 8m 24s
ogr-tests-pip-deps : FAILURE in 7m 45s
ogr-reverse-dep-packit-tests : SUCCESS in 22m 19s

lachmanfrantisek

Thanks for the progress!

Regarding the requre responses, I think we are doing too much here:

regenerating some response files (not needed probably)
renaming the response files to match the new (shorter) naming scheme (can be done in a separate commit or PR)
response files for the tests you've created (yes, those need to be here and are the only needed changes (specifically additions) of response files in this PR)

lachmanfrantisek · 2021-06-21T09:19:00Z

ogr/abstract.py

+class CommitStatus(Enum):
+    pending = 1
+    success = 2
+    failure = 3
+    error = 4
+    canceled = 5
+    running = 6
+    mergeable = 7
+    notmergeable = 8


I'm not sure merging those two use-cases together is a good idea. I can't think of any use where both mergeable and success/failure/.. makes sense.

I think others suggested using a new enum and get inspired by CommitStatus. Not to reuse CommitStatus.

lachmanfrantisek · 2021-06-21T09:24:59Z

ogr/services/gitlab/pull_request.py

+    @property
+    def merge_commit_status(self) -> CommitStatus:
+        if self._raw_pr.merge_status == "can_be_merged":
+            return CommitStatus.mergeable
+        else:
+            return CommitStatus.notmergeable


Here, we can convert all possible values to the newly created Enum. As we discussed at the arch meeting, we want to differentiate e.g. pending and notmergeable. So, I would not treat all statuses that are not can_be_merged as notmergeable since it can't easily be a false statement.

softwarefactory-project-zuul · 2021-06-21T16:24:40Z

Build failed.

pre-commit : SUCCESS in 2m 36s
ogr-tests-rpm : FAILURE in 7m 06s
ogr-tests-pip-deps : FAILURE in 7m 24s
ogr-reverse-dep-packit-tests : SUCCESS in 26m 31s

softwarefactory-project-zuul · 2021-06-21T19:50:13Z

Build failed.

pre-commit : SUCCESS in 4m 20s
ogr-tests-rpm : FAILURE in 7m 17s
ogr-tests-pip-deps : FAILURE in 6m 55s
ogr-reverse-dep-packit-tests : SUCCESS in 23m 45s

bcrocker15 · 2021-06-22T00:47:18Z

I did a 'git reset' to get back to the state before I attempted to
regenerate tests (PLUS the MergeCommitStatus changes we agreed on
today), so we're back to these errors:

=================================== FAILURES ===================================
______________________ PullRequests.test_merge_commit_sha ______________________

self = <tests.integration.github.test_pull_requests.PullRequests testMethod=test_merge_commit_sha>

def setUp(self):
    super().setUp()
    self.token = os.environ.get("GITHUB_TOKEN")
    if not Path(get_datafile_filename(obj=self)).exists() and not self.token:

-> raise EnvironmentError(
"You are in Requre write mode, please set proper GITHUB_TOKEN env variables"
)
E OSError: You are in Requre write mode, please set proper GITHUB_TOKEN env variables

class = <class 'tests.integration.github.base.GithubTests'>
self = <tests.integration.github.test_pull_requests.PullRequests testMethod=test_merge_commit_sha>

tests/integration/github/base.py:15: OSError
______________________ PullRequests.test_merge_commit_sha ______________________

self = <tests.integration.gitlab.test_pull_requests.PullRequests testMethod=test_merge_commit_sha>

def setUp(self):
    super().setUp()
    self.token = os.environ.get("GITLAB_TOKEN")

    if not Path(get_datafile_filename(obj=self)).exists() and not self.token:

-> raise EnvironmentError(
"You are in Requre write mode, please set GITLAB_TOKEN env variables"
E OSError: You are in Requre write mode, please set GITLAB_TOKEN env variables

class = <class 'tests.integration.gitlab.base.GitlabTests'>
self = <tests.integration.gitlab.test_pull_requests.PullRequests testMethod=test_merge_commit_sha>

tests/integration/gitlab/base.py:16: OSError
=========================== short test summary info ============================
FAILED tests/integration/github/test_pull_requests.py::PullRequests::test_merge_commit_sha
FAILED tests/integration/gitlab/test_pull_requests.py::PullRequests::test_merge_commit_sha
============= 2 failed, 372 passed, 2 skipped in 289.30s (0:04:49) =============
make: *** [Makefile:12: check] Error 1

and the requre-0.8.1 update did NOT seem to help.

softwarefactory-project-zuul · 2021-06-22T11:56:34Z

Build failed.

pre-commit : SUCCESS in 4m 28s
ogr-tests-rpm : FAILURE in 7m 15s
ogr-tests-pip-deps : FAILURE in 7m 19s
ogr-reverse-dep-packit-tests : SUCCESS in 24m 52s

softwarefactory-project-zuul · 2021-06-22T23:02:22Z

Build failed.

pre-commit : SUCCESS in 3m 49s
ogr-tests-rpm : FAILURE in 8m 50s
ogr-tests-pip-deps : FAILURE in 6m 52s
ogr-reverse-dep-packit-tests : SUCCESS in 24m 59s

softwarefactory-project-zuul · 2021-06-23T00:13:35Z

Build succeeded.

pre-commit : SUCCESS in 3m 46s
ogr-tests-rpm : SUCCESS in 7m 14s
ogr-tests-pip-deps : SUCCESS in 6m 45s
ogr-reverse-dep-packit-tests : SUCCESS in 21m 24s

bcrocker15 · 2021-06-23T00:30:18Z

I implemented code changes as suggested by Frantisek, making the
code much more idiomatically Python-esque.

With two new test_data files, note success on all Zuul tests!

TomasTomecek

\o/

lachmanfrantisek · 2021-06-23T06:38:31Z

tests/integration/gitlab/test_pull_requests.py

+    def test_merge_commit_sha(self):
+        pr1 = self.project.get_pr(1)
+        pr12 = self.project.get_pr(12)
+        pr19 = self.project.get_pr(19)
+        assert pr1.merge_commit_sha == "101a42bbbe174d04b465d49caf274dc3b4defeca"
+        assert pr1.merge_commit_status == MergeCommitStatus.can_be_merged
+        assert pr12.merge_commit_sha == "f6de56d97ec3ec74cd5194e79175162d9f969195"
+        assert pr12.merge_commit_status == MergeCommitStatus.can_be_merged
+        assert pr19.merge_commit_sha == "b8e18207cfdad954f1b3a96db34d0706b272e6cf"
+        assert pr19.merge_commit_status == MergeCommitStatus.can_be_merged


What about having some example with MergeCommitStatus.cannot_be_merged?

softwarefactory-project-zuul · 2021-06-24T13:22:40Z

Build failed.

pre-commit : NODE_FAILURE in 0s
ogr-tests-rpm : NODE_FAILURE in 0s
ogr-tests-pip-deps : NODE_FAILURE in 0s
ogr-reverse-dep-packit-tests : NODE_FAILURE in 0s

lachmanfrantisek · 2021-07-07T09:19:13Z

recheck

lachmanfrantisek

Just one change-request, otherwise LGTM.

Can you please take care of finishing this?

lachmanfrantisek · 2021-07-07T09:22:21Z

ogr/services/gitlab/pull_request.py

+    @property
+    def merge_commit_status(self) -> MergeCommitStatus:
+        status = self._raw_pr.merge_status
+        assert status in self._merge_commit_status


Suggested change

assert status in self._merge_commit_status

Using assert in the production code is not expected -- python, when run in the optimise mode, ignores such commands so we can't really on the execution of this.

Note that you are checking this one line bellow so it's not needed here.

Fixed by myself.

softwarefactory-project-zuul · 2021-07-07T09:43:35Z

Build failed.

pre-commit : FAILURE in 4m 47s
ogr-tests-rpm : SUCCESS in 7m 59s
ogr-tests-pip-deps : SUCCESS in 7m 35s
ogr-reverse-dep-packit-tests : SUCCESS in 23m 07s

Add merge_commit_sha and merge_commit_status properties to GithubPullRequest class (and PullRequest superclass); merge_commit_status returns a MergeCommitStatus. GitHub's 'mergeable' boolean maps to MergeCommitStatus.can_be_merged (true) or MergeCommitStatus.cannot_be_merged (false). GitLab's 'merge_status' string values map to MergeCommitStatus values verbatim. New test_pull_requests.py:test_merge_commit_sha methods for GitHub and GitLab. In Makefile, pass GITHUB_TOKEN, GITLAB_TOKEN in check-in-container OGR issue packit#584. Signed-off-by: Ben Crocker <[email protected]>

Signed-off-by: Ben Crocker <[email protected]>

The assert code is ignored when Python is run in the optimised mode. Signed-off-by: Frantisek Lachman <[email protected]>

lachmanfrantisek · 2021-07-12T07:03:45Z

I've rebased the PR myself so we can merge it.

softwarefactory-project-zuul · 2021-07-12T07:28:49Z

Build succeeded.

pre-commit : SUCCESS in 4m 04s
ogr-tests-rpm : SUCCESS in 6m 41s
ogr-tests-pip-deps : SUCCESS in 6m 42s
ogr-reverse-dep-packit-tests : SUCCESS in 24m 17s

lachmanfrantisek

@bcrocker15 thanks for working on this!

I've just rebased the PR for you and add one commit with a small fix I've mentioned in the comments but you still have the credits..;)

softwarefactory-project-zuul · 2021-07-12T07:42:08Z

Build succeeded (gate pipeline).

pre-commit : SUCCESS in 4m 58s

bcrocker15 requested review from TomasTomecek and mfocko June 13, 2021 01:06

bcrocker15 self-assigned this Jun 13, 2021

bcrocker15 linked an issue Jun 13, 2021 that may be closed by this pull request

[GitHub] Support using the merge ref instead of the head ref #584

Closed

TomasTomecek reviewed Jun 14, 2021

View reviewed changes

bcrocker15 force-pushed the ogr-issue-584 branch from 6419e72 to 5d3f5b5 Compare June 14, 2021 15:43

mfocko reviewed Jun 15, 2021

View reviewed changes

bcrocker15 force-pushed the ogr-issue-584 branch from 2e86a9c to 9906d16 Compare June 17, 2021 01:40

TomasTomecek reviewed Jun 18, 2021

View reviewed changes

bcrocker15 force-pushed the ogr-issue-584 branch from b0cf12e to 0005f29 Compare June 19, 2021 01:53

bcrocker15 force-pushed the ogr-issue-584 branch from 0005f29 to 2301bf8 Compare June 19, 2021 02:20

bcrocker15 force-pushed the ogr-issue-584 branch from 6bf8f63 to 17dcfa1 Compare June 19, 2021 19:06

lachmanfrantisek reviewed Jun 21, 2021

View reviewed changes

bcrocker15 force-pushed the ogr-issue-584 branch from 17dcfa1 to 4f2bfac Compare June 21, 2021 15:55

bcrocker15 force-pushed the ogr-issue-584 branch from 4f2bfac to ad7e67d Compare June 21, 2021 19:25

bcrocker15 force-pushed the ogr-issue-584 branch from ad7e67d to b0a1692 Compare June 22, 2021 11:30

bcrocker15 marked this pull request as ready for review June 22, 2021 11:32

bcrocker15 force-pushed the ogr-issue-584 branch from b0a1692 to b0eb598 Compare June 22, 2021 22:36

TomasTomecek approved these changes Jun 23, 2021

View reviewed changes

lachmanfrantisek approved these changes Jun 23, 2021

View reviewed changes

bcrocker15 force-pushed the ogr-issue-584 branch from 38c8e98 to 056f9a3 Compare June 24, 2021 13:05

lachmanfrantisek reviewed Jul 7, 2021

View reviewed changes

bcrocker15 and others added 3 commits July 12, 2021 09:02

New test_data files

b04c979

Signed-off-by: Ben Crocker <[email protected]>

Do not use assert in the production code

6e5bf1a

The assert code is ignored when Python is run in the optimised mode. Signed-off-by: Frantisek Lachman <[email protected]>

lachmanfrantisek force-pushed the ogr-issue-584 branch from 056f9a3 to 6e5bf1a Compare July 12, 2021 07:03

lachmanfrantisek approved these changes Jul 12, 2021

View reviewed changes

lachmanfrantisek added the mergeit When set, zuul wil gate and merge the PR. label Jul 12, 2021

softwarefactory-project-zuul bot merged commit 3809720 into packit:main Jul 12, 2021

mergeable	=> merge_status
True	"can_be_merged"
False	"cannot_be_merged"
<>	"unchecked"
<>	"checking"
<>	"cannot_be_merged_recheck"

Support using the merge ref instead of the head ref in a pull request #601

Support using the merge ref instead of the head ref in a pull request #601

Conversation

bcrocker15 commented Jun 13, 2021

softwarefactory-project-zuul bot commented Jun 13, 2021

TomasTomecek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lachmanfrantisek Jun 14, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcrocker15 Jun 15, 2021 • edited Loading

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jun 14, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jun 15, 2021

softwarefactory-project-zuul bot commented Jun 17, 2021

bcrocker15 commented Jun 17, 2021

bcrocker15 commented Jun 17, 2021

jscotka commented Jun 17, 2021 • edited Loading

softwarefactory-project-zuul bot commented Jun 17, 2021

bcrocker15 commented Jun 18, 2021

jscotka commented Jun 18, 2021 • edited Loading

TomasTomecek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jun 19, 2021

softwarefactory-project-zuul bot commented Jun 19, 2021

softwarefactory-project-zuul bot commented Jun 19, 2021

softwarefactory-project-zuul bot commented Jun 19, 2021

softwarefactory-project-zuul bot commented Jun 19, 2021

lachmanfrantisek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jun 21, 2021

softwarefactory-project-zuul bot commented Jun 21, 2021

bcrocker15 commented Jun 22, 2021

softwarefactory-project-zuul bot commented Jun 22, 2021

softwarefactory-project-zuul bot commented Jun 22, 2021

softwarefactory-project-zuul bot commented Jun 23, 2021

bcrocker15 commented Jun 23, 2021

TomasTomecek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jun 24, 2021

lachmanfrantisek commented Jul 7, 2021

lachmanfrantisek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jul 7, 2021

lachmanfrantisek commented Jul 12, 2021 • edited Loading

softwarefactory-project-zuul bot commented Jul 12, 2021

lachmanfrantisek left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jul 12, 2021

lachmanfrantisek Jun 14, 2021 •

edited

Loading

bcrocker15 Jun 15, 2021 •

edited

Loading

jscotka commented Jun 17, 2021 •

edited

Loading

jscotka commented Jun 18, 2021 •

edited

Loading

lachmanfrantisek commented Jul 12, 2021 •

edited

Loading