Fix merge_commit_sha for GitLab #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
Previous solution utilized only merge_commit, that is after merging MR. Since v0.20.0 python-gitlab supports test merges as GitHub. Fixes behaviour to be consistent with GitHub's. Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
fix-gitlab-merge-ref
branch
from
8a15981 to
789d320
Compare
|
Build succeeded.
|
jpopelka
approved these changes
Aug 5, 2021
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous solution utilized only merge_commit, that is after merging MR.
Since v0.20.0 python-gitlab supports test merges as GitHub. Fixes
behaviour to be consistent with GitHub's.
Fix bug and unify behaviour in
merge_commit_shafor GitLab MRs. Since python-gitlab v0.20.0, it is supported to create test merge. In case of merged pull requests on GitLabmerge_commit_shareturns the SHA of merge commit, otherwise provides SHA of the test merge commit.