Add Comment.react_to_the_comment, Comment.get_reactions, Reaction.delete #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikromen
force-pushed
the
+1-to-the-comment-command
branch
2 times, most recently
from
e558906 to
9944175
Compare
|
Build succeeded.
|
mfocko
reviewed
Aug 26, 2021
There was a problem hiding this comment.
LGTM, for the service-side part I would have a look at functools.partial, it might make it easier for you and reduce code duplication. 😉
Comment on lines
+31
to
+32
| ProjectIssueNoteAwardEmoji, | ||
| ProjectMergeRequestAwardEmoji, |
Comment on lines
272
to
273
| pr = self.service.get_project(repo="playground", namespace="nikromen").get_pr(4) | ||
| pr_comment = pr.comment(datetime.now().strftime("%m/%d/%Y")) |
There was a problem hiding this comment.
Ya, we should do fixtures for playground, comments, etc. as part of #445
nikromen
force-pushed
the
+1-to-the-comment-command
branch
4 times, most recently
from
57c1c7c to
2524638
Compare
|
Build succeeded.
|
Reaction.delete, Comment.react_to_comment, Comment.get_reactions added. Not supported by Pagure.
Added support for reacting to comment with given reaction, getting list of reactions on given comment and deleting given reaction.
nikromen
force-pushed
the
+1-to-the-comment-command
branch
from
2524638 to
12a04ad
Compare
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for reacting to comments, getting list of reactions and deleting reactions.
Also compatibility.md file - updated.
Fixes #630
Ogr now supports reacting to the comment with a given reaction, getting them in list and deleting them (only when reaction is added by using ogr API).