Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab list MRs: return all, not just 20 #819

Merged
merged 3 commits into from
Oct 27, 2023
+13,602 −1
Merged

gitlab list MRs: return all, not just 20 #819

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a2ae80
gitlab list MRs: return all, not just 20
TomasTomecek Oct 19, 2023
50ded3a
tests: add requre response and be explicit in test
mfocko Oct 26, 2023
79f2497
test_mr_list_limit: skip on old python-gitlab
TomasTomecek Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test_mr_list_limit: skip on old python-gitlab 
@mfocko wasn't able to reproduce locally what we experience in CI

since this involves old python-gitlab that soon will be unsupported,
let's skip it in the meantime

Signed-off-by: Tomas Tomecek <[email protected]>
@TomasTomecek
TomasTomecek committed Oct 26, 2023

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 332171FADF1DB90B
Learn about vigilant mode
commit 79f2497241f25afa3d701a01346525d263e9b368
5 changes: 5 additions & 0 deletions tests/integration/gitlab/test_pull_requests.py
View file
Original file line number Diff line number Diff line change
@@ -30,6 +30,11 @@ def test_pr_list(self):
assert title == pr_list[0].title
pr.close()

@pytest.mark.skipif(
is_gitlab_version_smaller_than_314(),
reason="URL syntax changed between versions and"
"our requre data don't work with older gitlab versions",
)
def test_mr_list_limit(self):
pr_list = self.project.get_pr_list(status=PRStatus.all)
count = len({pr.id for pr in pr_list})