Remove upstream_project_url check in validate-config

[lbarcziova]

This is no longer required.

RELEASE NOTES BEGIN

Check for upstream_project_url presence in the configuration when pull_from_upstream job is configured was removed from validate-config, as this is no longer required.

RELEASE NOTES END

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/bd3389ce64e8473aaec72186c8d8f3c1

✔️ pre-commit SUCCESS in 9m 09s
✔️ packit-tests-rpm SUCCESS in 23m 53s
✔️ packit-tests-pip-deps SUCCESS in 23m 52s
✔️ packit-tests-git-main SUCCESS in 24m 45s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 3m 13s
✔️ packit-tests-git-main-sess-rec SUCCESS in 3m 37s
✔️ reverse-dep-packit-service-tests SUCCESS in 4m 20s

[mfocko]

Do you think it would make sense to turn this error into a warning (something along the lines of “no upstream is configured, Packit Service jobs will be run as for non-git upstreams”) rather than removing it altogether?

IMO it could lead to some surprises

[lbarcziova]

@mfocko I don't think it should lead to any surprises, even before the support was implemented, adding the upstream_project_url was mostly an extra step for maintainers and in most of the cases they do not really need/expect the git interaction for upstream.

[mfocko]

/packit retest-failed

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0957e368891e4462a7809cb544e9f5fe

✔️ pre-commit SUCCESS in 2m 09s
✔️ packit-tests-rpm SUCCESS in 23m 44s
✔️ packit-tests-pip-deps SUCCESS in 23m 21s
✔️ packit-tests-git-main SUCCESS in 23m 43s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 3m 35s
✔️ packit-tests-git-main-sess-rec SUCCESS in 3m 33s
✔️ reverse-dep-packit-service-tests SUCCESS in 5m 11s

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c8d046c725594b5a81c7e4fc737fb5e3

✔️ pre-commit SUCCESS in 2m 03s