Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libraries and fix tests #1337

Merged
merged 7 commits into from
Jan 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: npm

- name: Set NodeJS scripts shell
if: startsWith(matrix.os, 'windows')
run: npm config set script-shell "C:\\Program Files\\git\\bin\\bash.exe"

- name: Install dependencies
run: |
npm ci
Expand Down Expand Up @@ -271,6 +275,14 @@ jobs:
node-version: ${{ env.STABLE_NODE_VERSION }}
cache: npm

# Temporary fix for lodash issue. This step should be removed eventually
# once a better solution is found.
- name: Install dependencies
run: npm ci

- name: Install plugins
run: npm run install-plugins

- name: Download dist folder
uses: actions/download-artifact@v4
with:
Expand Down
1 change: 0 additions & 1 deletion .nycrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"instrument": true,
"lines": 50,
"reporter": ["text-summary", "html", "lcov"],
"require": ["tsx"],
"sourceMap": true,
"statements": 50
}
2 changes: 1 addition & 1 deletion examples/graphql/src/consumer.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* tslint:disable:no-unused-expression object-literal-sort-keys max-classes-per-file no-empty */
import chai from 'chai';
import * as chai from 'chai';
import * as path from 'path';
import chaiAsPromised from 'chai-as-promised';
import { query } from './consumer';
Expand Down
2 changes: 1 addition & 1 deletion examples/typescript/test/get-dog.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* tslint:disable:no-unused-expression object-literal-sort-keys max-classes-per-file no-empty */
import chai from 'chai';
import * as chai from 'chai';
import chaiAsPromised from 'chai-as-promised';
import path = require('path');
import sinonChai from 'sinon-chai';
Expand Down
2 changes: 1 addition & 1 deletion examples/v3/typescript/test/user.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import chai from 'chai';
import * as chai from 'chai';
import chaiAsPromised from 'chai-as-promised';
import sinonChai from 'sinon-chai';
import { PactV3, MatchersV3, LogLevel } from '@pact-foundation/pact';
Expand Down
2 changes: 1 addition & 1 deletion examples/v4/matchers/consumer.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* tslint:disable:no-unused-expression no-empty */
import chai from 'chai';
import * as chai from 'chai';
import chaiAsPromised from 'chai-as-promised';
import {
SpecificationVersion,
Expand Down
2 changes: 1 addition & 1 deletion examples/v4/plugins/test/matt.consumer.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* tslint:disable:no-unused-expression no-empty */
import chai from 'chai';
import * as chai from 'chai';
import chaiAsPromised from 'chai-as-promised';
import { SpecificationVersion, PactV4, LogLevel } from '@pact-foundation/pact';
import net = require('net');
Expand Down
Loading
Loading