Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(whitelist): on module #95

Merged
merged 3 commits into from
Jan 7, 2025
Merged

feat(whitelist): on module #95

merged 3 commits into from
Jan 7, 2025

Conversation

Laudenlaruto
Copy link
Member

No description provided.

@Laudenlaruto Laudenlaruto marked this pull request as ready for review January 6, 2025 13:26
cterence
cterence requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@cterence cterence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d'une manière générale pour être cohérent sur le naming, est-ce qu'on remplacerait pas "whitelist" par "ignore" ?

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cterence
cterence requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@cterence cterence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remplacer ignoreing => ignoring

@Laudenlaruto Laudenlaruto merged commit 69cde76 into main Jan 7, 2025
1 check passed
@Laudenlaruto Laudenlaruto deleted the betterwhitelist branch January 7, 2025 14:50
@Laudenlaruto Laudenlaruto mentioned this pull request Jan 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cterence cterence cterence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Laudenlaruto @cterence