Padrino Command Exits Zero on Error

[sshaw]

Ran into a problem doing something like this:

/tmp/padrino-test >padrino stop && echo 'Success!'
=> tmp/pids/server.pid not found!
Success!

As you can see, padrino s wasn't running, yet it the command exited with 0.

This is also the case when trying to exec invalid commands:

/tmp/padrino-test >padrino whatwhatwhat && echo 'Success!'
Could not find command "whatwhatwhat".
Success!

Of course this is (to some extent) a Thor issue.

The second problem can be easily solved by adding the following to Padrino::Cli::Launcher:

protected
def exit_on_failure?
  true
end

Of course this assumes you don't want to maintain any sort of dependency on the current behavior.

Fixing the first problem seems a tad ugly and/or invasive:

1. Explicitly call exit 1 on failure
2. Raise Thor::Error on failures like the above and stuff like this
3. Just let errors propagate, you'll get non-zero but with a stacktrack -which is not too user friendly

[ujifgc]

Thank you for your report! Please tell if there's more commands failing to convey their failure.