Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

[#IC-344] Remove Legal Backup from Card unsubscription #84

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Mar 8, 2022

List of Changes

  • Add DeleteCgnOrchestratorV2
  • DeleteCardActivation now points to brand new Delete Orchestrator version (v2)

Motivation and Context

This PR is needed by legal in order to not track users that wants to unsubscribe to CGN.

How Has This Been Tested?

Unit tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

@CaraDune CaraDune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR improves the orchestrator that deletes personal data associated to the CGN after request by user without creating an automatic backup. This PR is requested and approved by the Developer's Legal Team according to the project DPIA (v. 1.5) that states that Beneficiary data are processed for the duration of the Beneficiary's membership in the Program and subsequently deleted, except for data contained in Messages, and unless in any case a claim or dispute arises. Manual backup may be created only upon instruction by the Controller (or by the Developer, as the case may be) if involved in the claim/dispute.

Copy link
Contributor

@michaeldisaro michaeldisaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just fix review.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
42.6% 42.6% Duplication

@AleDore AleDore merged commit 2e580cb into master Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants