Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

[#IOCIT-378] Added error event tracking #33

Merged
merged 9 commits into from
Apr 12, 2023
Merged

[#IOCIT-378] Added error event tracking #33

merged 9 commits into from
Apr 12, 2023

Conversation

michaeldisaro
Copy link
Contributor

@michaeldisaro michaeldisaro commented Mar 28, 2023

List of Changes

Added error event to ReservePubKey and ActivatePubKey functions.

Motivation and Context

We need error event tracking for troubleshooting reasons.

How Has This Been Tested?

  • yarn build
  • yarn lint
  • yarn test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCIT-378

@michaeldisaro michaeldisaro marked this pull request as ready for review March 31, 2023 14:39
@michaeldisaro michaeldisaro requested a review from a team as a code owner March 31, 2023 14:39
ActivatePubKey/handler.ts Outdated Show resolved Hide resolved
ActivatePubKey/handler.ts Outdated Show resolved Hide resolved
ActivatePubKey/handler.ts Outdated Show resolved Hide resolved
ActivatePubKey/__tests__/handler.test.ts Outdated Show resolved Hide resolved
ActivatePubKey/__tests__/handler.test.ts Outdated Show resolved Hide resolved
@michaeldisaro
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 89.36% and project coverage change: +0.27 🎉

Comparison is base (a298e95) 86.38% compared to head (a04e5b2) 86.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   86.38%   86.65%   +0.27%     
==========================================
  Files          23       22       -1     
  Lines         727      712      -15     
  Branches       64       60       -4     
==========================================
- Hits          628      617      -11     
+ Misses         95       91       -4     
  Partials        4        4              
Impacted Files Coverage Δ
utils/errors.ts 85.00% <ø> (-1.67%) ⬇️
ActivatePubKey/handler.ts 84.31% <80.00%> (+2.09%) ⬆️
ReservePubKey/handler.ts 80.95% <80.00%> (-0.13%) ⬇️
GenerateLCParams/handler.ts 88.57% <100.00%> (+2.85%) ⬆️
GetAssertion/handler.ts 90.00% <100.00%> (ø)
...ls/middleware/http_message_signature_middleware.ts 88.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gquadrati gquadrati merged commit 6330309 into master Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants