Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

[#IOPID-146] Remove duplicated events #36

Merged
merged 5 commits into from
Apr 17, 2023
Merged

[#IOPID-146] Remove duplicated events #36

merged 5 commits into from
Apr 17, 2023

Conversation

gquadrati
Copy link
Contributor

List of Changes

See commit history

Motivation and Context

Fix duplicated event generation

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gquadrati gquadrati requested a review from a team as a code owner April 12, 2023 10:57
@github-actions
Copy link

github-actions bot commented Apr 12, 2023

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-146

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Patch coverage: 91.83% and project coverage change: +0.61 🎉

Comparison is base (a298e95) 86.38% compared to head (a14d8d7) 86.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   86.38%   86.99%   +0.61%     
==========================================
  Files          23       22       -1     
  Lines         727      715      -12     
  Branches       64       63       -1     
==========================================
- Hits          628      622       -6     
+ Misses         95       89       -6     
  Partials        4        4              
Impacted Files Coverage Δ
utils/errors.ts 85.00% <ø> (-1.67%) ⬇️
ActivatePubKey/handler.ts 84.31% <80.00%> (+2.09%) ⬆️
GenerateLCParams/handler.ts 88.57% <100.00%> (+2.85%) ⬆️
GetAssertion/handler.ts 90.00% <100.00%> (ø)
ReservePubKey/handler.ts 86.04% <100.00%> (+4.96%) ⬆️
...ls/middleware/http_message_signature_middleware.ts 88.88% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gquadrati gquadrati changed the title [#iocit-378] Remove duplicated events [#IOCIT-378] Remove duplicated events Apr 12, 2023
@gquadrati gquadrati requested a review from BurnedMarshal April 12, 2023 14:32
@gquadrati gquadrati changed the title [#IOCIT-378] Remove duplicated events [#IOPID-146] Remove duplicated events Apr 17, 2023
ReservePubKey/handler.ts Outdated Show resolved Hide resolved
ReservePubKey/__tests__/handler.test.ts Show resolved Hide resolved
ReservePubKey/__tests__/handler.test.ts Show resolved Hide resolved
@gquadrati gquadrati requested a review from BurnedMarshal April 17, 2023 10:59
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gquadrati gquadrati merged commit a8aa549 into master Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants