Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

[#IOPID-106] add assertionRef to exception, enable sampling #41

Merged
merged 1 commit into from
May 3, 2023
Merged

[#IOPID-106] add assertionRef to exception, enable sampling #41

merged 1 commit into from
May 3, 2023

Conversation

gquadrati
Copy link
Contributor

List of Changes

  • Add assertionRef to exception properties
  • Enable sampling
  • Update tests

Motivation and Context

Enable the ability to retrieve assertionRef when all retries have failed.

How Has This Been Tested?

Unit tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gquadrati gquadrati requested a review from a team as a code owner May 2, 2023 11:03
@gquadrati gquadrati requested review from arcogabbo and Garma00 May 2, 2023 11:04
@github-actions
Copy link

github-actions bot commented May 2, 2023

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-106

@gquadrati gquadrati requested a review from BurnedMarshal May 2, 2023 12:16
arcogabbo
arcogabbo approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@arcogabbo arcogabbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gquadrati gquadrati merged commit bbbc0de into master May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arcogabbo arcogabbo arcogabbo approved these changes

@Garma00 Garma00 Awaiting requested review from Garma00 Garma00 was automatically assigned from pagopa/io-backend-contributors

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gquadrati @arcogabbo