Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

[#IOPID-1944] Upgrade appingights sdk and config #51

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BurnedMarshal
Copy link
Contributor

@BurnedMarshal BurnedMarshal commented Jun 28, 2024

⚠️ Depends on pagopa/io-infra#1057

List of Changes

Extend the configuration with the Appisights connection string and cloud role name
Update libraries related with appinsights dependency

Motivation and Context

We need to upgrade the AppInsights sdk for better and more accurate monitoring.

How Has This Been Tested?

local execution

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@BurnedMarshal BurnedMarshal requested a review from a team as a code owner June 28, 2024 12:30
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1944

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (9bc1d0f) to head (3ec9441).
Report is 13 commits behind head on master.

Files Patch % Lines
utils/appinsights.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   87.34%   87.09%   -0.26%     
==========================================
  Files          22       22              
  Lines         735      744       +9     
  Branches       63       64       +1     
==========================================
+ Hits          642      648       +6     
- Misses         89       92       +3     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

dpulls bot commented Dec 17, 2024

🎉 All dependencies have been resolved !

@BurnedMarshal
Copy link
Contributor Author

@arcogabbo can we close this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants