Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPLT-62] Adds all static const and types #1

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Jun 28, 2023

Short description

This PR includes the basic utils and variables to setup the new design system project

@CrisTofani CrisTofani requested review from dmnplb and a team June 28, 2023 13:07
@CrisTofani CrisTofani marked this pull request as ready for review June 28, 2023 13:13
@CrisTofani CrisTofani requested a review from a team June 28, 2023 13:13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A modest suggestion: why don't we delete them? Theoretically, all the new components don't reference these values. If we delete them, we can also quickly detect the technical debt because we have errors in the specific components.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13a1929 as suggested, may you check anything's ok?

@CrisTofani CrisTofani requested a review from dmnplb June 30, 2023 15:27
@CrisTofani CrisTofani merged commit 83e4439 into main Jul 3, 2023
@CrisTofani CrisTofani deleted the IOPLT-62-global-utils branch July 3, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants