Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPLT-195] Fixes the accessibility issue preventing to intercept the closing button on banner #109

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR aims to fix the accessibility on the Banner component

List of changes proposed in this pull request

  • Changes the accessibility attributes on Banner component

How to test

Check how voiceover intercepts each element of a banner

@CrisTofani CrisTofani requested review from dmnplb and a team as code owners October 18, 2023 14:44
@CrisTofani CrisTofani merged commit 9963f6b into main Oct 19, 2023
@CrisTofani CrisTofani deleted the IOPLT-195-banner-accessibility branch October 19, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants