Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPLT-230] GradientBottomActions refinement #126

Merged
merged 9 commits into from
Nov 6, 2023

Conversation

drmarro
Copy link
Contributor

@drmarro drmarro commented Nov 2, 2023

Short description

Refining GradientBottomActions component. It actually has two generic parameters (firstAction and secondAction): these two params has to be specific components (ButtonSolid or ButtonLink).

List of changes proposed in this pull request

  • GradientBottomActions
  • ButtonSolid
  • ButtonLInk

@drmarro drmarro requested review from dmnplb and a team as code owners November 2, 2023 10:21
src/components/layout/GradientBottomActions.tsx Outdated Show resolved Hide resolved
src/components/layout/GradientBottomActions.tsx Outdated Show resolved Hide resolved
src/components/layout/common.ts Outdated Show resolved Hide resolved
src/components/layout/GradientBottomActions.tsx Outdated Show resolved Hide resolved
src/components/layout/GradientScrollView.tsx Outdated Show resolved Hide resolved
@CrisTofani CrisTofani requested a review from dmnplb November 6, 2023 14:30
Copy link
Collaborator

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just final changes and then we can get it approved 👍🏻

src/components/layout/GradientBottomActions.tsx Outdated Show resolved Hide resolved
src/components/layout/GradientBottomActions.tsx Outdated Show resolved Hide resolved
src/components/layout/GradientScrollView.tsx Outdated Show resolved Hide resolved
@drmarro drmarro merged commit 4a5869d into main Nov 6, 2023
2 checks passed
@drmarro drmarro deleted the IOPLT-230-sticky-button-refactoring branch November 6, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants