[IOPLT-133] Implements NumberPad component #127
Conversation
| import { IOIconSizeScale, IOIcons } from "../icons"; | ||
| import { NumberButton } from "./NumberButton"; | ||
|
|
||
| type BiometricAuthProps = |
There was a problem hiding this comment.
can this type be just :
type BiometricAuthProps = {
biometricType?: BiometricsValidType;
onBiometricPress?: () => void;
biometricAccessibilityLabel?: string;
};
There was a problem hiding this comment.
Using the union type here defined we can handle the constraint of having all three props none of them defined at the same time: if we have a biometric option the tercet must be valorized correctly
|
|
||
| type ButtonType = "biometric" | "delete"; | ||
|
|
||
| const RowButtons = ({ |
There was a problem hiding this comment.
Could this component be extracted as a standalone, reusable component, separate from the NumberPad?
There was a problem hiding this comment.
Actually this should be only a local component avoiding code duplication to repeat button lines. Do you see any other possible usage of the component? 😄
fixed in d684d67 |
Short description
This PR creates the new NumberPad component
List of changes proposed in this pull request
NumberPadcomponentHow to test
Check related screen in example app
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-11-02.at.15.38.31.mp4