Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPLT-171] Introduces CodeInput component #143

Merged
merged 10 commits into from
Nov 23, 2023
Merged

[IOPLT-171] Introduces CodeInput component #143

merged 10 commits into from
Nov 23, 2023

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Nov 22, 2023 •
edited
Loading

Short description

This PR introduces CodeInput component

How to test

Check NumberPad screen to view new CodeInput component features

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-11-22.at.17.23.07.mp4

@CrisTofani CrisTofani requested review from dmnplb and a team as code owners November 22, 2023 16:26
dmnplb
dmnplb requested changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@dmnplb dmnplb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly improved the shake animation, but the main issue is that CodeInput renders the filled circle with black fill color, instead of the white one if the screen background is blue

@CrisTofani
Copy link
Contributor Author

Slightly improved the shake animation, but the main issue is that CodeInput renders the filled circle with black fill color, instead of the white one if the screen background is blue

Not a real bug, just didn't map the correct variant to the blueBackground state, fixed in b2350ec

@CrisTofani CrisTofani requested a review from dmnplb November 23, 2023 14:32
@CrisTofani CrisTofani merged commit 0ac642b into main Nov 23, 2023
2 checks passed
@CrisTofani CrisTofani deleted the IOPLT-171-code-input-component branch November 23, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmnplb dmnplb dmnplb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrisTofani @dmnplb