Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor of the Toast Provider component #146

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

StefanoFrontini
Copy link
Contributor

Short description

remove useEffect and fix chidren with the same key prop error

List of changes proposed in this pull request

  • removes useEffect in order to simplify the code and avoid unnecessary rerender
  • Fix the error: two children have the same key prop

How to test

Check the Toasts page of example app.

@StefanoFrontini StefanoFrontini requested review from dmnplb and a team as code owners November 23, 2023 15:34
@CrisTofani CrisTofani changed the title refactor of the Toast Provider component chore: Refactor of the Toast Provider component Nov 24, 2023
@CrisTofani CrisTofani merged commit 8985d7c into main Nov 24, 2023
2 checks passed
@CrisTofani CrisTofani deleted the ToastRefactor branch November 24, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants