Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOBP-429] listItemHeader value variant #157

Conversation

forrest57
Copy link
Contributor

Short description

introduction of said variant
Screenshot 2023-11-30 at 10 34 33

List of changes proposed in this pull request

  • added props and component for said variant
  • added playground entry

How to test

yarn test, also you can just run the example app

@forrest57 forrest57 requested review from dmnplb and a team as code owners November 30, 2023 09:37
Copy link
Collaborator

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that this ListItemHeader is a very specific component for payments, and it's not always used as a header section (see here and here), I think a separate component with a specific purpose is a better fit (ListItemInfoAmount or ListItemAmount?).

We can assemble it in a modular way, thanks to the typographic styles already available (H6, etc...). Also note that the new ListItem should have a loading state for the amount (see the comment here).

What do you think?

@forrest57
Copy link
Contributor Author

Considering that this ListItemHeader is a very specific component for payments, and it's not always used as a header section (see here and here), I think a separate component with a specific purpose is a better fit (ListItemInfoAmount or ListItemAmount?).

We can assemble it in a modular way, thanks to the typographic styles already available (H6, etc...). Also note that the new ListItem should have a loading state for the amount (see the comment here).

What do you think?

you're right, it probably is better to divide them!
done in 2fc4a08, LMK what you think and sorry for making you wait 😅

@CrisTofani CrisTofani requested a review from dmnplb January 22, 2024 15:22
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dmnplb wait for your approval

@forrest57 forrest57 merged commit ef877cd into main Jan 26, 2024
2 checks passed
@forrest57 forrest57 deleted the IOBP-429-ds-realizzazione-componente-list-item-header-variante-con-value branch January 26, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants