-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOBP-429] listItemHeader value variant #157
[IOBP-429] listItemHeader value variant #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that this ListItemHeader
is a very specific component for payments, and it's not always used as a header section (see here and here), I think a separate component with a specific purpose is a better fit (ListItemInfoAmount
or ListItemAmount
?).
We can assemble it in a modular way, thanks to the typographic styles already available (H6
, etc...). Also note that the new ListItem should have a loading state for the amount (see the comment here).
What do you think?
…em-header-variante-con-value
…em-header-variante-con-value
…em-header-variante-con-value
…em-header-variante-con-value
…em-header-variante-con-value
…em-header-variante-con-value
…em-header-variante-con-value
…em-header-variante-con-value
…em-header-variante-con-value
you're right, it probably is better to divide them! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @dmnplb wait for your approval
…em-header-variante-con-value
…em-header-variante-con-value
…em-header-variante-con-value
…em-header-variante-con-value
Short description
introduction of said variant
List of changes proposed in this pull request
How to test
yarn test, also you can just run the example app