Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added optional accessibility label for the icon on the Tag element #181

Merged
merged 1 commit into from
Jan 29, 2024
Merged

chore: added optional accessibility label for the icon on the Tag element #181

merged 1 commit into from
Jan 29, 2024

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR adds the accessibility label property for the icon of the Tag element.

List of changes proposed in this pull request

  • Added an optional string for the accessibility label that is forwarded to the the Icon component (that already supports accessbiility)

@Vangaorth Vangaorth requested review from dmnplb and a team as code owners January 29, 2024 09:34
@Vangaorth Vangaorth merged commit abc5b89 into main Jan 29, 2024
2 checks passed
@Vangaorth Vangaorth deleted the chore/tagAccessibility branch January 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmnplb dmnplb dmnplb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vangaorth @dmnplb