Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IACROSS-218] Add Titillium Sans Pro to all Titillium based typographic styles #182

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Jan 29, 2024

Short description

This PR applies the new Titillium Sans Pro (official repo) to all the typographic styles that already use Titillium Web in both versions (legacy and new). Therefore, the new typeface will only be visibile when the experimental DS is enabled.

List of changes proposed in this pull request

  • Update all the Titillium-based typographic styles
  • Update ModulePaymentNotice to use the LabelSmallAlt style if experimental DS is enabled
  • Update the Typography screen in the example app

How to test

  1. Run the example app
  2. Go to the Typography page

@dmnplb dmnplb requested review from a team as code owners January 29, 2024 15:33
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in order to keep Storybook working properly we need to add the mapping here too

@dmnplb
Copy link
Collaborator Author

dmnplb commented Jan 29, 2024

Add path to fonts for Storybook compatibility

Addressed in the commit a7e94c7

@dmnplb dmnplb requested a review from CrisTofani January 29, 2024 17:13
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb merged commit c240dd2 into main Jan 30, 2024
2 checks passed
@dmnplb dmnplb deleted the IACROSS-218-add-titillium-sans-pro branch January 30, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants