Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Add ModuleAttachment, fix accessibility on ListItemHeader #188

Merged
merged 6 commits into from
Feb 9, 2024
Merged

[chore] Add ModuleAttachment, fix accessibility on ListItemHeader #188

merged 6 commits into from
Feb 9, 2024

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR add the ModuleAttachment component and fixes accessibility on Android for ListItemHeader

List of changes proposed in this pull request

  • Added ModuleAttachment
  • ListItemHeader's label ignores accessibility on Android if the parent view is marked as accessibile (this avoid a double reading of such label - iOS is not affected)

@Vangaorth
Adds ModuleAttachment
bb9f7c2 
Fixes accessibility on ListItemHeader on Android (which was reading the label twice)
@Vangaorth Vangaorth requested review from dmnplb and a team as code owners February 6, 2024 13:39
@Vangaorth Vangaorth mentioned this pull request Feb 9, 2024
Merged
CrisTofani
CrisTofani requested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from required changes, we need to add the new component in the example app and storybook for documentation purpose

src/components/listitems/ListItemHeader.tsx Show resolved Hide resolved
@Vangaorth
Copy link
Contributor Author

Apart from required changes, we need to add the new component in the example app and storybook for documentation purpose

Done it!

@CrisTofani CrisTofani merged commit 87d3b78 into main Feb 9, 2024
2 checks passed
@CrisTofani CrisTofani deleted the features/moduleAttachment branch February 9, 2024 16:03
CrisTofani pushed a commit that referenced this pull request Feb 9, 2024
@Vangaorth
[chore] Icon accessibility (#190)
7e2e8ca 
This PR depends on #188 

## Short description
This PR fixes the accessibility on the Icon component, which was always
disabled.

## List of changes proposed in this pull request
- specific iOS and Android properties are toggled based on the
accessibility data

## How to test
Check that both TalkBack and VoiceOver read the accessibility label when
it is specified and ignore it when it is not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

@dmnplb dmnplb Awaiting requested review from dmnplb dmnplb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vangaorth @CrisTofani